Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update with-orbit-components README #74011

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Marukome0743
Copy link
Contributor

What?

Remove below 2 lines from with-orbit-components README.md.

For this purpose we are extending `<App />` of injected `<ThemeProvider/>`, and also adding `@kiwicom/babel-plugin-orbit-components`.

This fork comes from [styled-components-example](https://github.com/vercel/next.js/tree/canary/examples/with-styled-components).

Why?

At #73266, Both <ThemeProvider/> and @kiwicom/babel-plugin-orbit-components were deleted.
In addition, styled-components isn't used anymore.

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 17, 2024
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: e549934

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review December 17, 2024 02:00
@samcx
Copy link
Member

samcx commented Dec 17, 2024

@Marukome0743 Nice catch!

@samcx samcx enabled auto-merge (squash) December 17, 2024 02:00
@samcx samcx merged commit dc4ed7c into vercel:canary Dec 17, 2024
39 checks passed
@Marukome0743 Marukome0743 deleted the orbit branch December 17, 2024 02:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants