Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork react-dev-overlay for new UI #74017

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 17, 2024

This PR forked the UI essentials of react dev overlay to _experimental dir (_ underscore to keep it displayed at the top).

Also, modified the existing ReactDevOverlay component to conditionally render the New and Old component based on the given __NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY env.

Please note that there might be redundant forks within _experimental/internal, but will continue to reduce them on the following PRs.

Closes NDX-589

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 17, 2024
Copy link
Member Author

devjiwonchoi commented Dec 17, 2024

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
buildDuration 22s 20.4s N/A
buildDurationCached 18.9s 16.5s N/A
nodeModulesSize 410 MB 415 MB ⚠️ +4.96 MB
nextStartRea..uration (ms) 530ms 550ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
1187-HASH.js gzip 51.1 kB 51.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
middleware-b..fest.js gzip 673 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 354 kB ⚠️ +30.2 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 314 kB 344 kB ⚠️ +30.1 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39 kB 39 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.42 MB ⚠️ +60.3 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui Change
0.pack gzip 2.06 MB 2.07 MB ⚠️ +2.83 kB
index.pack gzip 72.1 kB 73.1 kB ⚠️ +1 kB
Overall change 2.13 MB 2.14 MB ⚠️ +3.83 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js

Diff too large to display

Commit: 076d5df

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 17, 2024 12:06
@devjiwonchoi devjiwonchoi marked this pull request as draft December 17, 2024 12:21
@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 17, 2024 15:04
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from 504ca63 to ca41632 Compare December 17, 2024 15:07
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from ca41632 to e086c37 Compare December 17, 2024 16:35
@devjiwonchoi devjiwonchoi changed the base branch from canary to 12-17-delete_unused_groupedstackframes.tsx_ December 17, 2024 16:35
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from e086c37 to b291d84 Compare December 17, 2024 16:48
@devjiwonchoi devjiwonchoi requested a review from huozhi December 17, 2024 17:07
@devjiwonchoi devjiwonchoi changed the base branch from 12-17-delete_unused_groupedstackframes.tsx_ to graphite-base/74017 December 17, 2024 17:19
devjiwonchoi added a commit that referenced this pull request Dec 17, 2024
Following of #74017 (comment).
This PR removed unused file from dev overlay: `GroupedStackFrames.tsx`.
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from cd1f3d0 to a95f901 Compare December 17, 2024 17:19
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74017 to canary December 17, 2024 17:20
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from a95f901 to 076d5df Compare December 17, 2024 17:20
Copy link
Member Author

devjiwonchoi commented Dec 18, 2024

Merge activity

  • Dec 17, 8:19 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 8:20 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi merged commit 035f161 into canary Dec 18, 2024
130 checks passed
@devjiwonchoi devjiwonchoi deleted the 12-17-fork_react-dev-overlay_for_new_ui branch December 18, 2024 01:20
@github-actions github-actions bot added the locked label Jan 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants