-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork react-dev-overlay
for new UI
#74017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
buildDuration | 22s | 20.4s | N/A |
buildDurationCached | 18.9s | 16.5s | N/A |
nodeModulesSize | 410 MB | 415 MB | |
nextStartRea..uration (ms) | 530ms | 550ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
1187-HASH.js gzip | 51.1 kB | 51.1 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 235 B | N/A |
main-HASH.js gzip | 34.1 kB | 34 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 746 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
index.html gzip | 524 B | 523 B | N/A |
link.html gzip | 539 B | 537 B | N/A |
withRouter.html gzip | 520 B | 519 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 204 kB | 204 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 673 B | 668 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
523-experime...dev.js gzip | 322 B | 322 B | ✓ |
523.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 323 kB | 354 kB | |
app-page-exp..prod.js gzip | 127 kB | 127 kB | ✓ |
app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
app-page-tur..prod.js gzip | 135 kB | 135 kB | ✓ |
app-page.run...dev.js gzip | 314 kB | 344 kB | |
app-page.run..prod.js gzip | 123 kB | 123 kB | ✓ |
app-route-ex...dev.js gzip | 37.4 kB | 37.4 kB | ✓ |
app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
app-route.ru...dev.js gzip | 39 kB | 39 kB | ✓ |
app-route.ru..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.4 kB | 27.4 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.36 MB | 2.42 MB |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 12-17-fork_react-dev-overlay_for_new_ui | Change | |
---|---|---|---|
0.pack gzip | 2.06 MB | 2.07 MB | |
index.pack gzip | 72.1 kB | 73.1 kB | |
Overall change | 2.13 MB | 2.14 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
Diff too large to display
Tests Passed |
huozhi
reviewed
Dec 17, 2024
...nents/react-dev-overlay/_experimental/internal/container/RuntimeError/GroupedStackFrames.tsx
Outdated
Show resolved
Hide resolved
huozhi
reviewed
Dec 17, 2024
packages/next/src/client/components/react-dev-overlay/pages/ReactDevOverlay.tsx
Outdated
Show resolved
Hide resolved
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 15:07
504ca63
to
ca41632
Compare
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 16:35
ca41632
to
e086c37
Compare
devjiwonchoi
changed the base branch from
canary
to
12-17-delete_unused_groupedstackframes.tsx_
December 17, 2024 16:35
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 16:48
e086c37
to
b291d84
Compare
devjiwonchoi
changed the base branch from
12-17-delete_unused_groupedstackframes.tsx_
to
graphite-base/74017
December 17, 2024 17:19
devjiwonchoi
added a commit
that referenced
this pull request
Dec 17, 2024
Following of #74017 (comment). This PR removed unused file from dev overlay: `GroupedStackFrames.tsx`.
devjiwonchoi
force-pushed
the
graphite-base/74017
branch
from
December 17, 2024 17:19
c61ec57
to
81d2175
Compare
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 17:19
cd1f3d0
to
a95f901
Compare
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 17:20
a95f901
to
076d5df
Compare
eps1lon
approved these changes
Dec 17, 2024
huozhi
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forked the UI essentials of react dev overlay to
_experimental
dir (_
underscore to keep it displayed at the top).Also, modified the existing
ReactDevOverlay
component to conditionally render the New and Old component based on the given__NEXT_EXPERIMENTAL_NEW_DEV_OVERLAY
env.Please note that there might be redundant forks within
_experimental/internal
, but will continue to reduce them on the following PRs.Closes NDX-589