Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify PPR test dimension via environment variable only #74031

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 17, 2024

We can create separate Jest projects instead if there's a desire to run a test with and without PPR.
But in this current state, the test was executed twice for each PPR state:
once in the PPR CI shard with PPR enabled and once in the non-PPR CI shard with PPR enabled

We can create separate Jest projects instead if there's
a desire to run a test with and without PPR.
But in this current state, the test was executed twice for each PPR state:
once in the PPR CI shard with PPR enabled and once in the
non-PPR CI shard with PPR enabled
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Dec 17, 2024
Copy link
Member Author

eps1lon commented Dec 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon requested review from wyattjoh and ztanner December 17, 2024 16:36
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
buildDuration 20s 23.7s ⚠️ +3.7s
buildDurationCached 15.8s 13.5s N/A
nodeModulesSize 410 MB 410 MB N/A
nextStartRea..uration (ms) 488ms 490ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
1187-HASH.js gzip 51.1 kB 50.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB N/A
app-page-exp..prod.js gzip 127 kB 127 kB N/A
app-page-tur..prod.js gzip 140 kB 140 kB N/A
app-page-tur..prod.js gzip 135 kB 135 kB N/A
app-page.run...dev.js gzip 314 kB 314 kB N/A
app-page.run..prod.js gzip 123 kB 123 kB N/A
app-route-ex...dev.js gzip 37.4 kB 37.4 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39 kB 39 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.02 MB 1.02 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only Change
0.pack gzip 2.06 MB 2.06 MB N/A
index.pack gzip 71.5 kB 73 kB ⚠️ +1.49 kB
Overall change 71.5 kB 73 kB ⚠️ +1.49 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: b77d0c8

@eps1lon eps1lon marked this pull request as ready for review December 17, 2024 22:00
@eps1lon eps1lon merged commit da2a87a into canary Dec 18, 2024
130 checks passed
@eps1lon eps1lon deleted the sebbie/12-17-specify_ppr_test_dimension_via_environment_variable_only branch December 18, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants