Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added fallback source route to prerender manifest #74052

Merged

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Dec 18, 2024

When serving partial generated shells, the prerender manifest needs to annotate which source file is associated with the given route. This adds the new field for dynamic routes.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 18, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wyattjoh wyattjoh marked this pull request as ready for review December 18, 2024 01:09
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
buildDuration 21.6s 19.7s N/A
buildDurationCached 18.6s 15.8s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +3.8 kB
nextStartRea..uration (ms) 547ms 550ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
1187-HASH.js gzip 51.4 kB 51.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 324 kB 324 kB
app-page-exp..prod.js gzip 128 kB 128 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page-tur..prod.js gzip 136 kB 136 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 124 kB 124 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-fix_added_fallback_source_route_to_prerender_manifest Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +612 B
index.pack gzip 73.7 kB 73.6 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +612 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 58577f8

@wyattjoh wyattjoh merged commit 9a968b2 into canary Dec 18, 2024
123 of 128 checks passed
@wyattjoh wyattjoh deleted the 12-17-fix_added_fallback_source_route_to_prerender_manifest branch December 18, 2024 01:25
@github-actions github-actions bot added the locked label Jan 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants