Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware handler for error code telemetry #74088

Merged

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Dec 18, 2024

This pull request adds telemetry collection for error message feedback in the development server. It exposes an internal endpoint /__nextjs_error_feedback for the error overlay to call.

https://linear.app/vercel/issue/NDX-597/create-error-feedback-ui-that-fires-events-to-next-telemetry

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 18, 2024
@gaojude gaojude changed the title add middleware handler for error code telemetry Add middleware handler for error code telemetry Dec 18, 2024
Copy link
Contributor Author

gaojude commented Dec 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gaojude gaojude marked this pull request as ready for review December 18, 2024 19:29
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
buildDuration 18s 15.8s N/A
buildDurationCached 15.1s 12.6s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +23.3 kB
nextStartRea..uration (ms) 478ms 476ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 231 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
middleware-b..fest.js gzip 668 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 356 kB 356 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 346 kB 346 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.43 MB 2.43 MB
build cache
vercel/next.js canary vercel/next.js 12-18-add_middleware_handler_for_error_code_telemetry Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 75.2 kB 74.1 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: d1d9d53

@gaojude gaojude merged commit 58d3982 into canary Dec 18, 2024
137 checks passed
@gaojude gaojude deleted the 12-18-add_middleware_handler_for_error_code_telemetry branch December 18, 2024 20:55
@github-actions github-actions bot added the locked label Jan 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants