Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve types in turbopack runtime #74119

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Dec 19, 2024

adds types to node modules require()d in the node runtime. these imports were untyped, which was hiding an issue with our pathToFileUrl usage.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 19, 2024
@@ -82,7 +82,7 @@ function createResolvePathFromModule(
strippedAssetPrefix
);

return url.pathToFileURL(resolved);
return url.pathToFileURL(resolved).href;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathToFileURL returns a URL, not a string like the signature of createResolvePathFromModule says. not sure which one is correct -- this was a URL for quite some time i guesss, but i'm guessing a string is what we actually want?

@lubieowoce lubieowoce changed the title fix: add types to node imports in turbopack runtime fix: improve types in turbopack runtime Dec 19, 2024
@lubieowoce lubieowoce marked this pull request as ready for review December 19, 2024 04:27
@lubieowoce lubieowoce requested review from mischnic and bgw December 19, 2024 04:27
@ijjk
Copy link
Member

ijjk commented Dec 19, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
buildDuration 19.4s 15.9s N/A
buildDurationCached 15.1s 12.5s N/A
nodeModulesSize 416 MB 416 MB
nextStartRea..uration (ms) 475ms 474ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
index.html gzip 524 B 524 B
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 356 kB 356 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 347 kB 347 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.43 MB 2.43 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js lubieowoce/turbo-runtime-typed-imports Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +4.57 kB
index.pack gzip 73.8 kB 74.7 kB ⚠️ +862 B
Overall change 2.15 MB 2.16 MB ⚠️ +5.43 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 302315e

@ijjk
Copy link
Member

ijjk commented Dec 19, 2024

Failing test suites

Commit: 75a4163

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

  • persistent-caching > should persistent cache loaders
Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1734583660025"
Received: "Timestamp = 1734583681698"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

@lubieowoce lubieowoce force-pushed the lubieowoce/turbo-runtime-typed-imports branch from 75a4163 to 302315e Compare December 19, 2024 18:45
@lubieowoce lubieowoce enabled auto-merge (squash) December 19, 2024 18:45
@lubieowoce lubieowoce merged commit f533b97 into canary Dec 19, 2024
128 of 129 checks passed
@lubieowoce lubieowoce deleted the lubieowoce/turbo-runtime-typed-imports branch December 19, 2024 19:12
@github-actions github-actions bot added the locked label Jan 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants