-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix @vercel/og license SPDX expression #74745
Conversation
ae4027d
to
a212a36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Failing test suitesCommit: ca8f428
Expand output● Required Server Files › production mode › should output required-server-files manifest correctly
● Required Server Files › production mode › should render SSR page correctly
● Required Server Files › production mode › should render dynamic SSR page correctly
● Required Server Files › production mode › should render fallback page correctly
● Required Server Files › production mode › should render SSR page correctly with x-matched-path
● Required Server Files › production mode › should render dynamic SSR page correctly with x-matched-path
● Required Server Files › production mode › should render fallback page correctly with x-matched-path and routes-matches
● Required Server Files › production mode › should return data correctly with x-matched-path
● Required Server Files › production mode › should render fallback optional catch-all route correctly with x-matched-path and routes-matches
● Required Server Files › production mode › should return data correctly with x-matched-path for optional catch-all route
● Required Server Files › production mode › should not apply trailingSlash redirect
● Required Server Files › production mode › should normalize catch-all rewrite query values correctly
● Required Server Files › production mode › should bubble error correctly for gip page
● Required Server Files › production mode › should bubble error correctly for gssp page
● Required Server Files › production mode › should bubble error correctly for gsp page
● Required Server Files › production mode › should normalize optional values correctly for SSP page
● Required Server Files › production mode › should normalize optional values correctly for SSG page
● Required Server Files › production mode › should normalize optional values correctly for API page
● Required Server Files › production mode › should match the index page correctly
● Required Server Files › production mode › should match the root dynamic page correctly
● Required Server Files › production mode › should handle 404s properly
● Test suite failed to run
Read more about building and testing Next.js in contributing.md.
Expand output● Cleaning distDir › production mode › should clean up .next before build start
● Cleaning distDir › production mode › disabled write › should not clean up .next before build start
Read more about building and testing Next.js in contributing.md.
Expand output● persistent-caching › should persistent cache loaders
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
buildDuration | 40.4s | 35.6s | N/A |
buildDurationCached | 33.8s | 29.5s | N/A |
nodeModulesSize | 417 MB | 417 MB | ✓ |
nextStartRea..uration (ms) | 1s | 1s | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
5306-HASH.js gzip | 53.3 kB | 53.3 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 240 B | 242 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 53 kB | 53 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
index.html gzip | 522 B | 521 B | N/A |
link.html gzip | 538 B | 535 B | N/A |
withRouter.html gzip | 518 B | 518 B | ✓ |
Overall change | 518 B | 518 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 207 kB | 207 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 667 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 367 kB | 367 kB | ✓ |
app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 138 kB | 138 kB | ✓ |
app-page.run...dev.js gzip | 355 kB | 355 kB | ✓ |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.46 MB | 2.46 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | matmannion/next.js fix-vercel-og-license | Change | |
---|---|---|---|
0.pack gzip | 2.09 MB | 2.09 MB | N/A |
index.pack gzip | 75.2 kB | 75.4 kB | |
Overall change | 75.2 kB | 75.4 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
### What? A minor fix to the `package.json` for `@vercel/og`; there is a typo on the SPDX license ID for MPL-2.0 which is causing the license ID to not be correctly extracted by some automated tooling (one example is https://github.com/CycloneDX/cyclonedx-webpack-plugin, meaning that the license ID isn't correctly identified). ### Why? For apps that use automated tooling to generate an exhaustive list of dependencies, it's useful to have the license identified automatically and for this to be a valid SPDX identifier to be able to group dependencies together. Co-authored-by: Jiachi Liu <inbox@huozhi.im>
What?
A minor fix to the
package.json
for@vercel/og
; there is a typo on the SPDX license ID for MPL-2.0 which is causing the license ID to not be correctly extracted by some automated tooling (one example is https://github.com/CycloneDX/cyclonedx-webpack-plugin, meaning that the license ID isn't correctly identified).Why?
For apps that use automated tooling to generate an exhaustive list of dependencies, it's useful to have the license identified automatically and for this to be a valid SPDX identifier to be able to group dependencies together.