Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track dynamic IO feature usage #74942

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

gaojude
Copy link
Contributor

@gaojude gaojude commented Jan 15, 2025

Extend https://nextjs.org/telemetry to cover usages of dynamic IO

Closes NDX-673

Copy link
Contributor Author

gaojude commented Jan 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gaojude gaojude marked this pull request as ready for review January 15, 2025 19:24
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
buildDuration 16.6s 15s N/A
buildDurationCached 14.3s 11.9s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +1.67 kB
nextStartRea..uration (ms) 416ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
5306-HASH.js gzip 53.9 kB 53.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache
vercel/next.js canary vercel/next.js jude/telemetry-ppr-dynamic-io Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75.9 kB 74.7 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 02c907d

@gaojude gaojude force-pushed the jude/telemetry-ppr-dynamic-io branch from 7d96c81 to 02c907d Compare January 15, 2025 19:36
@gaojude gaojude changed the title track next.js telemetry for dynaimc io and ppr Track dynamic IO feature usage Jan 15, 2025
@ijjk
Copy link
Member

ijjk commented Jan 15, 2025

Failing test suites

Commit: 02c907d

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

  • ReactRefreshRequire > propagates a module that stops accepting in next version
Expand output

● ReactRefreshRequire › propagates a module that stops accepting in next version

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
    "init BarV2",
    "init FooV1",
+   "init BarV2",
  ]

  440 |     // Since the export list changed, we have to re-run both the parent
  441 |     // and the child.
> 442 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  443 |       'init BarV2',
  444 |       'init FooV1',
  445 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:442:63)

Read more about building and testing Next.js in contributing.md.

@gaojude gaojude requested review from ijjk and ztanner January 15, 2025 19:44
@gaojude gaojude merged commit eef6342 into canary Jan 15, 2025
131 of 133 checks passed
@gaojude gaojude deleted the jude/telemetry-ppr-dynamic-io branch January 15, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants