-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Turbopack] Production Chunking #75010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
labels
Jan 16, 2025
This was referenced Jan 16, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
buildDuration | 17.1s | 15.3s | N/A |
buildDurationCached | 14.5s | 12.1s | N/A |
nodeModulesSize | 418 MB | 418 MB | N/A |
nextStartRea..uration (ms) | 416ms | 417ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
5306-HASH.js gzip | 54 kB | 54 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.44 kB | 5.44 kB | N/A |
bccd1874-HASH.js gzip | 52.9 kB | 52.9 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 241 B | 241 B | ✓ |
main-HASH.js gzip | 34.4 kB | 34.4 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.57 kB | 4.57 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
index.html gzip | 524 B | 524 B | ✓ |
link.html gzip | 538 B | 538 B | ✓ |
withRouter.html gzip | 519 B | 521 B | N/A |
Overall change | 1.06 kB | 1.06 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 208 kB | 208 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 669 B | 667 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 374 kB | 374 kB | ✓ |
app-page-exp..prod.js gzip | 130 kB | 130 kB | ✓ |
app-page-tur..prod.js gzip | 143 kB | 143 kB | ✓ |
app-page-tur..prod.js gzip | 139 kB | 139 kB | ✓ |
app-page.run...dev.js gzip | 362 kB | 362 kB | ✓ |
app-page.run..prod.js gzip | 126 kB | 126 kB | ✓ |
app-route-ex...dev.js gzip | 37.6 kB | 37.6 kB | ✓ |
app-route-ex..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.6 kB | 25.6 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
pages.runtim...dev.js gzip | 27.7 kB | 27.7 kB | ✓ |
pages.runtim..prod.js gzip | 21.9 kB | 21.9 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.47 MB | 2.47 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js sokra/production-chunking | Change | |
---|---|---|---|
0.pack gzip | 2.1 MB | 2.09 MB | N/A |
index.pack gzip | 74.8 kB | 75.5 kB | |
Overall change | 74.8 kB | 75.5 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
sokra
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
from
January 17, 2025 07:46
95f402a
to
578cf3c
Compare
sokra
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 07:46
a448706
to
116b4dc
Compare
sokra
changed the title
prepare for production chunking
[Turbopack] Production Chunking
Jan 17, 2025
mischnic
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
from
January 17, 2025 10:00
578cf3c
to
20e7703
Compare
mischnic
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 10:05
116b4dc
to
c4593a9
Compare
sokra
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
from
January 17, 2025 10:23
20e7703
to
60dfb5a
Compare
sokra
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 10:23
c4593a9
to
f3b357e
Compare
mischnic
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 11:19
f3b357e
to
71a13ba
Compare
sokra
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
2 times, most recently
from
January 17, 2025 13:28
5a38367
to
22dc976
Compare
sokra
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 13:28
71a13ba
to
2a95b98
Compare
sokra
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
from
January 17, 2025 13:30
22dc976
to
bf12547
Compare
sokra
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 13:30
2a95b98
to
c742c89
Compare
mischnic
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
2 times, most recently
from
January 17, 2025 14:07
75bc35d
to
068f13d
Compare
mischnic
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 14:07
c742c89
to
3ed57b5
Compare
mischnic
force-pushed
the
wbinnssmith/chunk-graph-single-module
branch
from
January 17, 2025 16:25
068f13d
to
072d710
Compare
mischnic
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 16:25
3ed57b5
to
4009be4
Compare
sokra
added
the
CI Bypass Graphite Optimization
Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci
label
Jan 17, 2025
Base automatically changed from
wbinnssmith/chunk-graph-single-module
to
canary
January 17, 2025 19:57
sokra
force-pushed
the
sokra/production-chunking
branch
from
January 17, 2025 19:58
4009be4
to
45f0c24
Compare
This was referenced Jan 17, 2025
mischnic
reviewed
Jan 20, 2025
Comment on lines
1011
to
1015
if next_mode.is_development() { | ||
builder = builder.use_file_source_map_uris(); | ||
} else { | ||
builder = builder.ecmascript_chunking_config(ChunkingConfig {}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this for now, but it's somewhat surprising that .ecmascript_chunking_config(ChunkingConfig {})
alone enables production chunking.
mischnic
approved these changes
Jan 20, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI Bypass Graphite Optimization
Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci
created-by: Turbopack team
PRs by the Turbopack team.
Turbopack
Related to Turbopack with Next.js.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a very simple version of Production Chunking for ecmascript which creates chunks in a way that completely avoids duplicating modules.
Future PRs will add more heuristics to that like a minimum chunk size or a maximum number of requests.
Closes PACK-3767