Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when output: export is used with intercepting routes #75058

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 18, 2025

Intercepting routes are built on top of rewrites which is one of the listed unsupported features of output: "export".

However, because the Next.js server injects the interception routes, it's not caught by existing validation logic in the export flow.

This properly documents that intercepting routes are not currently supported by output: "export" and hard errors in next dev/build if detected. Previously route interception would just not have worked, instead serving the non-intercepted page when built, leading to a confusing experience.

We eventually want to support this with improved SPA/export features, however that's out of scope for this PR: the goal here is to ensure we're providing more immediate feedback about the fact that this is unsupported.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests type: next labels Jan 18, 2025
Copy link
Member Author

ztanner commented Jan 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ztanner ztanner force-pushed the 01-17-error_when_output_export_is_used_with_intercepting_routes branch from 7fa3379 to 0372aff Compare January 18, 2025 00:25
@ijjk
Copy link
Member

ijjk commented Jan 18, 2025

Tests Passed

@ztanner ztanner force-pushed the 01-17-error_when_output_export_is_used_with_intercepting_routes branch 3 times, most recently from 4ae5f17 to 25e8e7e Compare January 18, 2025 00:42
@ijjk
Copy link
Member

ijjk commented Jan 18, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
buildDuration 16.7s 15.2s N/A
buildDurationCached 14.2s 11.9s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +14.6 kB
nextStartRea..uration (ms) 414ms 422ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
index.html gzip 523 B 523 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
middleware-b..fest.js gzip 669 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-17-error_when_output_export_is_used_with_intercepting_routes Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +1.51 kB
index.pack gzip 74.1 kB 74.8 kB ⚠️ +745 B
Overall change 2.17 MB 2.17 MB ⚠️ +2.26 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 57b8bdb

@ztanner ztanner force-pushed the 01-17-error_when_output_export_is_used_with_intercepting_routes branch 2 times, most recently from 7af83d8 to 6dbafe6 Compare January 18, 2025 00:56
@ztanner ztanner marked this pull request as ready for review January 18, 2025 01:26
@ztanner ztanner force-pushed the 01-17-error_when_output_export_is_used_with_intercepting_routes branch from 6dbafe6 to 57b8bdb Compare January 18, 2025 17:35
@ztanner ztanner merged commit 808d2ba into canary Jan 18, 2025
132 checks passed
@ztanner ztanner deleted the 01-17-error_when_output_export_is_used_with_intercepting_routes branch January 18, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants