Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: don't create span for parallel chunking type #75094

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Turbopack: don't create span for parallel chunking type #75094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions turbopack/crates/turbopack-core/src/module_graph/mod.rs
View file
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ use petgraph::{
visit::{Dfs, EdgeRef, IntoNodeReferences, VisitMap, Visitable},
};
use serde::{Deserialize, Serialize};
use tracing::Instrument;
use tracing::{Instrument, Span};
use turbo_rcstr::RcStr;
use turbo_tasks::{
debug::ValueDebugFormat,
@@ -1077,14 +1077,17 @@ impl Visit<SingleModuleGraphBuilderNode> for SingleModuleGraphBuilder<'_> {
source_ident,
target_ident,
..
} => {
tracing::info_span!(
"chunkable reference",
ty = debug(chunking_type),
source = display(source_ident),
target = display(target_ident)
)
}
} => match chunking_type {
ChunkingType::Parallel => Span::current(),
_ => {
tracing::info_span!(
"chunkable reference",
ty = debug(chunking_type),
source = display(source_ident),
target = display(target_ident)
)
}
},
SingleModuleGraphBuilderNode::VisitedModule { .. } => {
tracing::info_span!("visited module")
}

Unchanged files with check annotations Beta

View file
crates/next-core/src/util.rs
/// Determines if the module is an internal asset (i.e overlay, fallback) coming
/// from the embedded FS, don't apply user defined transforms.
///
/// [TODO] turbopack specific embed fs should be handled by internals of

Check warning on line 147 in crates/next-core/src/util.rs

GitHub Actions / rustdoc check / build 

unresolved link to `TODO`
/// turbopack itself and user config should not try to leak this. However,
/// currently we apply few transform options subject to next.js's configuration
/// even if it's embedded assets.
View file
crates/napi/src/next_api/project.rs
}
}
/// Subscribes to lifecycle events of the compilation.

Check warning on line 1015 in crates/napi/src/next_api/project.rs

GitHub Actions / rustdoc check / build 

public documentation for `project_update_info_subscribe` links to private item `UpdateMessage::Start`

Check warning on line 1015 in crates/napi/src/next_api/project.rs

GitHub Actions / rustdoc check / build 

public documentation for `project_update_info_subscribe` links to private item `UpdateMessage::End`

Check warning on line 1015 in crates/napi/src/next_api/project.rs

GitHub Actions / rustdoc check / build 

public documentation for `project_update_info_subscribe` links to private item `UpdateMessage::End`

Check warning on line 1015 in crates/napi/src/next_api/project.rs

GitHub Actions / rustdoc check / build 

public documentation for `project_update_info_subscribe` links to private item `UpdateMessage::Start`
///
/// Emits an [UpdateMessage::Start] event when any computation starts.
/// Emits an [UpdateMessage::End] event when there was no computation for the