Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: optimize NftJsonAsset #75105

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 20, 2025

before:
aggregated NftJsonAsset::content 2.13s ⌀22.38ms (24.10s ⌀253.66ms) (11.3x)
aggregated NftJsonAsset::content [1032.29MB ⌀10.87MB] ([6.37GB ⌀67.10MB])
total build: 266.84s user 58.97s system 748% cpu 43.505 total
total memory: 16.74gb
Bildschirmfoto 2025-01-20 um 14 24 10

after:
aggregated NftJsonAsset::content 480.67ms ⌀5.06ms (4.97s ⌀52.31ms) (10.3x)
aggregated NftJsonAsset::content [119.08MB ⌀1253.44kB] ([1819.16MB ⌀19.15MB])
total build: 255.72s user 55.15s system 735% cpu 42.241 total
total memory: 15.84bg
Bildschirmfoto 2025-01-20 um 14 30 38

Closes PACK-3774

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 20, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic requested a review from sokra January 20, 2025 14:11
@mischnic mischnic marked this pull request as ready for review January 20, 2025 14:12
@ijjk
Copy link
Member

ijjk commented Jan 20, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
buildDuration 19.2s 17.6s N/A
buildDurationCached 16.6s 14s N/A
nodeModulesSize 418 MB 418 MB
nextStartRea..uration (ms) 444ms 443ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
index.html gzip 524 B 524 B
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 375 kB 375 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 363 kB 363 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/optimize-nftjsonasset Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +4.67 kB
index.pack gzip 74.5 kB 74.6 kB ⚠️ +129 B
Overall change 2.17 MB 2.17 MB ⚠️ +4.79 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 375ea44

@mischnic mischnic changed the title Optimize NftJsonAsset Turbopack: optimize NftJsonAsset Jan 20, 2025
@mischnic mischnic merged commit 4d9a985 into canary Jan 20, 2025
132 checks passed
@mischnic mischnic deleted the mischnic/optimize-nftjsonasset branch January 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants