Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbopack] Low hanging fixes and improvement on module graph #75106

Merged
merged 12 commits into from
Jan 20, 2025
Merged

[Turbopack] Low hanging fixes and improvement on module graph #75106

merged 12 commits into from
Jan 20, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 20, 2025 •
edited by padmaia
Loading

What?

Performance and memory fixes during creation of the module graph

-30% memory on module graph, -20% runtime on module graph

  • fix apply_esm_specific_options caching
  • avoid resolve task for get_exports
  • avoid analyse created items being turbo-tasks functions
  • avoid reading created Vc
  • determine module type per directory
  • reduce resolve tasks
  • make some functions in module processing non-turbo-tasks-functions, avoid reference type in apply_module_type
  • add Option<Vc>::to_resolved
  • make esm_resolve a normal function
  • make resolve_asset a non-turbo-tasks-function

Closes PACK-3775

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 20, 2025
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Jan 20, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 20, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
buildDuration 17.5s 15.6s N/A
buildDurationCached 14.7s 12.9s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 417ms 416ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
middleware-b..fest.js gzip 671 B 670 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 375 kB 375 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 143 kB 143 kB ✓
app-page-tur..prod.js gzip 139 kB 139 kB ✓
app-page.run...dev.js gzip 363 kB 363 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 27.7 kB 27.7 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.47 MB 2.47 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/reduce-tasks Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +2.05 kB
index.pack gzip 75.3 kB 74.1 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +2.05 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 37df9cf

@sokra sokra changed the title fix apply_esm_specific_options caching [Turbopack] Low hanging fixes and improvement on module graph Jan 20, 2025
@sokra sokra marked this pull request as ready for review January 20, 2025 14:49
@sokra sokra requested a review from mischnic January 20, 2025 14:49
mischnic
mischnic reviewed Jan 20, 2025
View reviewed changes
turbopack/crates/turbopack-ecmascript/src/lib.rs
return Ok(ModuleTypeResult::new(SpecifiedModuleType::Automatic));
};

// analysis.add_reference(PackageJsonReference::new(package_json));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be relevant for nft...
Not sure why it's commented out...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I only moved the code. It was commented out before

@mischnic mischnic merged commit 6ac9b21 into canary Jan 20, 2025
132 checks passed
@mischnic mischnic deleted the sokra/reduce-tasks branch January 20, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @mischnic