Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak static generation retry wait time #75381

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 28, 2025

Currently when retrying workers we wait somewhere between 0-500ms. This is to add a variable amount of jitter but the timeout is still fairly short. This tweaks it to ensure we're somewhere between 500-2000ms and adds a jitter value up to 30% of the base delay value to ensure large amounts of SSG failures don't cause a thundering herd problem on retry.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 28, 2025
Copy link
Member Author

ztanner commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ztanner ztanner marked this pull request as ready for review January 28, 2025 01:02
@ijjk
Copy link
Member

ijjk commented Jan 28, 2025

Tests Passed

@ztanner ztanner requested review from sokra and ijjk January 28, 2025 01:04
@ijjk
Copy link
Member

ijjk commented Jan 28, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
buildDuration 17.8s 15.8s N/A
buildDurationCached 14.9s 12.4s N/A
nodeModulesSize 392 MB 392 MB ⚠️ +4.11 kB
nextStartRea..uration (ms) 430ms 428ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
5306-HASH.js gzip 54.1 kB 54.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
index.html gzip 524 B 524 B
link.html gzip 539 B 539 B
withRouter.html gzip 519 B 521 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
middleware-b..fest.js gzip 668 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page.run...dev.js gzip 372 kB 372 kB N/A
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.4 kB 39.4 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 41 kB 41 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB
pages-api.ru...dev.js gzip 11.5 kB 11.5 kB
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB
pages-turbo...prod.js gzip 21.6 kB 21.6 kB
pages.runtim...dev.js gzip 31.3 kB 31.3 kB N/A
pages.runtim..prod.js gzip 21.6 kB 21.6 kB
server.runti..prod.js gzip 73.7 kB 73.7 kB
Overall change 1.25 MB 1.25 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-27-tweak_static_generation_retry_wait_time Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +791 B
index.pack gzip 75.8 kB 76.3 kB ⚠️ +564 B
Overall change 2.18 MB 2.18 MB ⚠️ +1.35 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for pages.runtime.dev.js

Diff too large to display

Commit: 29119dc

@ztanner ztanner merged commit 0ef3521 into canary Jan 28, 2025
132 checks passed
@ztanner ztanner deleted the 01-27-tweak_static_generation_retry_wait_time branch January 28, 2025 02:05
@bgw
Copy link
Member

bgw commented Jan 28, 2025

Nice. Exponential random backoff is 🐐.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants