Only reference published `@types/react-dom` versions #75606

eps1lon · 2025-02-03T11:26:53Z

Only affects installs without a lockfile. Otherwise it used the one we have specified in resolutions. I almost want to keep it to flush out installs without lockfiles but still: referencing non-existing versions is confusing.

eps1lon · 2025-02-03T11:27:07Z

Fix rustflags in *-musl builds #75603
Only reference published @types/react-dom versions #75606 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2025-02-07T14:18:16Z

Failing test suites

Commit: 3cadf6f

pnpm test-start-turbo test/e2e/app-dir/build-size/index.test.ts (turbopack)

app-dir build size > should have correct size in build output

Expand output

● app-dir build size › should have correct size in build output

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-start test/e2e/app-dir/action-in-pages-router/action-in-pages-router.test.ts (PPR)

app-dir - action-in-pages-router > should not error on fake server action in pages router
app-dir - action-in-pages-router > should not contain server action in page bundle
app-dir - action-in-pages-router > should not contain server action in manifest

Expand output

● app-dir - action-in-pages-router › should not error on fake server action in pages router

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● app-dir - action-in-pages-router › should not contain server action in page bundle

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

● app-dir - action-in-pages-router › should not contain server action in manifest

next build failed with code/signal 1

   98 |           if (code || signal)
   99 |             reject(
> 100 |               new Error(`next build failed with code/signal ${code || signal}`)
      |               ^
  101 |             )
  102 |           else resolve()
  103 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:100:15)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

persistent-caching > should persistent cache loaders

Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1738938487920"
Received: "Timestamp = 1738938506193"

  55 |       const browser = await next.browser('/pages')
  56 |       // TODO Persistent Caching for webpack dev server is broken
> 57 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  58 |       await browser.close()
  59 |     }
  60 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:57:57)

Read more about building and testing Next.js in contributing.md.

ijjk · 2025-02-07T14:23:50Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
buildDuration	18.3s	15.6s	N/A
buildDurationCached	14.7s	12.3s	N/A
nodeModulesSize	392 MB	392 MB	✓
nextStartRea..uration (ms)	417ms	397ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	1.04 kB	1.04 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
middleware-b..fest.js gzip	674 B	672 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
app-page-exp...dev.js gzip	393 kB	393 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	1.67 MB	1.67 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sebbie/02-03-only_reference_published_types/react-dom_versions	Change
0.pack gzip	2.1 MB	2.1 MB	⚠️ +137 B
index.pack gzip	75.7 kB	74.5 kB	N/A
Overall change	2.1 MB	2.1 MB	⚠️ +137 B

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 3cadf6f

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Feb 3, 2025

eps1lon mentioned this pull request Feb 3, 2025

Fix rustflags in *-musl builds #75603

Merged

1 task

eps1lon marked this pull request as ready for review February 3, 2025 14:20

eps1lon requested a review from huozhi February 3, 2025 14:21

huozhi approved these changes Feb 3, 2025

View reviewed changes

eps1lon enabled auto-merge (squash) February 5, 2025 13:32

Only reference published @types/react-dom versions

3cadf6f

eps1lon force-pushed the sebbie/02-03-only_reference_published_types/react-dom_versions branch from 6a835a0 to 3cadf6f Compare February 7, 2025 14:04

eps1lon merged commit e57a546 into canary Feb 7, 2025
131 checks passed

eps1lon deleted the sebbie/02-03-only_reference_published_types/react-dom_versions branch February 7, 2025 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only reference published `@types/react-dom` versions #75606

Only reference published `@types/react-dom` versions #75606

eps1lon commented Feb 3, 2025 •

edited

Loading

eps1lon commented Feb 3, 2025 •

edited

Loading

ijjk commented Feb 7, 2025 •

edited

Loading

ijjk commented Feb 7, 2025

Only reference published @types/react-dom versions #75606

Only reference published @types/react-dom versions #75606

Conversation

eps1lon commented Feb 3, 2025 • edited Loading

eps1lon commented Feb 3, 2025 • edited Loading

ijjk commented Feb 7, 2025 • edited Loading

Failing test suites

ijjk commented Feb 7, 2025

Stats from current PR

Only reference published `@types/react-dom` versions #75606

Only reference published `@types/react-dom` versions #75606

eps1lon commented Feb 3, 2025 •

edited

Loading

eps1lon commented Feb 3, 2025 •

edited

Loading

ijjk commented Feb 7, 2025 •

edited

Loading