Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example for multiple tags in cacheTag usage #75693

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Iftee97
Copy link
Contributor

@Iftee97 Iftee97 commented Feb 5, 2025

The documentation for the cacheTag function incorrectly showed multiple tags being passed as separate arguments. However, cacheTag expects an array of tags. This update corrects the example by passing the tags as an array.

  • Changed the example from cacheTag('tag-one', 'tag-two') to cacheTag(['tag-one', 'tag-two']).
  • Clarified that multiple tags should be passed as an array to avoid confusion.

This change improves clarity for developers using the cacheTag function.

The documentation for the `cacheTag` function incorrectly showed multiple tags being passed as separate arguments. However, `cacheTag` expects an array of tags. This update corrects the example by passing the tags as an array.

- Changed the example from `cacheTag('tag-one', 'tag-two')` to `cacheTag(['tag-one', 'tag-two'])`.
- Clarified that multiple tags should be passed as an array to avoid confusion.

This change improves clarity for developers using the `cacheTag` function.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Feb 5, 2025
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Allow CI Workflow Run

  • approve CI run for commit: 2c8557d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Feb 5, 2025

Allow CI Workflow Run

  • approve CI run for commit: 2c8557d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Iftee97
Copy link
Contributor Author

Iftee97 commented Feb 5, 2025

@leerob @delbaoliveira

@leerob leerob merged commit 674d32b into vercel:canary Feb 5, 2025
38 of 43 checks passed
@ijjk ijjk mentioned this pull request Feb 5, 2025
ijjk added a commit that referenced this pull request Feb 5, 2025
Seems this was failing in #75693
@laugharn
Copy link
Contributor

laugharn commented Feb 6, 2025

image

@leerob I might be missing something but I'm not sure this change was correct.

@leerob
Copy link
Member

leerob commented Feb 6, 2025

@leerob leerob mentioned this pull request Feb 6, 2025
leerob added a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants