fix: ensure lint worker errors aren't silenced #75766

ztanner · 2025-02-06T21:40:24Z

Errors thrown by the lint worker would only surface the error if JEST_WORKER_ID is present. This check was not reliably truthy in all cases (eg, when run with the vercel CLI, JEST_WORKER_ID wasn't present) which meant the build would fail with no helpful error message. Outside of that, it was a brittle check because if jest-worker ever changed or removed this env, or we replaced the underlying worker library, this would start failing.

This updates the check to be a more explicit env variable that we control.

There's an existing test for this but unfortunately it didn't repro in the test environment.

Test plan:

CI=1 npx next build
Ensure it errors

Fixes NEXT-3994

ztanner · 2025-02-06T21:40:49Z

fix: ensure lint worker errors aren't silenced #75766 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ztanner · 2025-02-06T21:44:56Z

packages/next/src/lib/worker.ts

@@ -75,7 +76,7 @@ export class Worker {
          worker._child?.on('exit', (code, signal) => {
            if ((code || (signal && signal !== 'SIGINT')) && this._worker) {
              logger.error(
-                `Static worker exited with code: ${code} and signal: ${signal}`


drive-by rename since we use this for more than just SSG

ijjk · 2025-02-06T21:51:05Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
buildDuration	19.6s	17.8s	N/A
buildDurationCached	16.9s	14.1s	N/A
nodeModulesSize	392 MB	392 MB	⚠️ +524 B
nextStartRea..uration (ms)	471ms	463ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
5306-HASH.js gzip	54.2 kB	54.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	52.9 kB	52.9 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	240 B	242 B	N/A
main-HASH.js gzip	34.5 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
index.html gzip	524 B	523 B	N/A
link.html gzip	539 B	538 B	N/A
withRouter.html gzip	520 B	520 B	✓
Overall change	520 B	520 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
middleware-b..fest.js gzip	674 B	673 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
app-page-exp...dev.js gzip	393 kB	393 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	✓
app-page.run..prod.js gzip	128 kB	128 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.5 kB	60.5 kB	✓
Overall change	1.67 MB	1.67 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-06-fix_ensure_lint_worker_errors_aren_t_silenced	Change
0.pack gzip	2.1 MB	2.11 MB	⚠️ +1.22 kB
index.pack gzip	74.1 kB	75.7 kB	⚠️ +1.65 kB
Overall change	2.18 MB	2.18 MB	⚠️ +2.86 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: ee1ee78

Errors thrown by the lint worker would only surface the error if `JEST_WORKER_ID` is present. This check was not reliably truthy in all cases (eg, when run with the vercel CLI, `JEST_WORKER_ID` wasn't present) which meant the build would fail with no helpful error message. Outside of that, it was a brittle check because if jest-worker ever changed or removed this env, or we replaced the underlying worker library, this would start failing. This updates the check to be a more explicit env variable that we control. Fixes NEXT-3994

Backports: - #75766

#75779) Backports: - #75766

fix: ensure lint worker errors aren't silenced

ee1ee78

ijjk added created-by: Next.js team PRs by the Next.js team. tests type: next labels Feb 6, 2025

ztanner marked this pull request as ready for review February 6, 2025 21:43

ztanner requested a review from ijjk February 6, 2025 21:43

ztanner commented Feb 6, 2025

View reviewed changes

ijjk approved these changes Feb 6, 2025

View reviewed changes

ztanner enabled auto-merge (squash) February 6, 2025 21:50

ztanner merged commit 8ee2d3f into canary Feb 6, 2025
132 checks passed

ztanner deleted the 02-06-fix_ensure_lint_worker_errors_aren_t_silenced branch February 6, 2025 21:59

This was referenced Feb 7, 2025

[backport v15] fix: ensure lint worker errors aren't silenced (#75766) #75778

Merged

[backport v14] fix: ensure lint worker errors aren't silenced (#75766) #75779

Merged

ztanner added a commit that referenced this pull request Feb 10, 2025

fix: ensure lint worker errors aren't silenced (#75766) (#75778)

0d9f605

Backports: - #75766

ztanner added a commit that referenced this pull request Feb 10, 2025

[backport v14] fix: ensure lint worker errors aren't silenced (#75766) (

c482c20

#75779) Backports: - #75766

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure lint worker errors aren't silenced #75766

fix: ensure lint worker errors aren't silenced #75766

ztanner commented Feb 6, 2025 •

edited

Loading

ztanner commented Feb 6, 2025

ztanner Feb 6, 2025

ijjk commented Feb 6, 2025

fix: ensure lint worker errors aren't silenced #75766

fix: ensure lint worker errors aren't silenced #75766

Conversation

ztanner commented Feb 6, 2025 • edited Loading

ztanner commented Feb 6, 2025

ztanner Feb 6, 2025

Choose a reason for hiding this comment

ijjk commented Feb 6, 2025

Stats from current PR

ztanner commented Feb 6, 2025 •

edited

Loading