[error overlay] fix missing html error is not displayed

[huozhi]

What

[data-nextjs-dialog-content] was set to height: 100%, which has conflicted with useMeasureHeight hook. data-nextjs-dialog-content] 's parent is always controlled by useMeasureHeight, and the height is anmiating from 0 to the child height. If the child is aligned with that parent, then the height is always 0, which lead to not displayed

Closes NDX-797

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
buildDuration	18.8s	15.5s	N/A
buildDurationCached	14.7s	12.5s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	403ms	418ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
5306-HASH.js gzip	54.3 kB	54.3 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	✓
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	246 B	N/A
main-HASH.js gzip	34.6 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	53 kB	53 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
index.html gzip	522 B	523 B	N/A
link.html gzip	538 B	538 B	✓
withRouter.html gzip	518 B	520 B	N/A
Overall change	538 B	538 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
middleware-b..fest.js gzip	676 B	670 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
app-page-exp...dev.js gzip	394 kB	394 kB	N/A
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	N/A
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	60.7 kB	60.7 kB	✓
Overall change	897 kB	897 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js huozhi/02-09-fix_missing_html_error	Change
0.pack gzip	2.11 MB	2.11 MB	⚠️ +4.36 kB
index.pack gzip	76.6 kB	75.6 kB	N/A
Overall change	2.11 MB	2.11 MB	⚠️ +4.36 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Commit: b6af822

[ijjk]

Failing test suites

Commit: b6af822

pnpm test-dev test/e2e/socket-io/index.test.js

• socket-io > should support socket.io without falling back to polling

Expand output

● socket-io › should support socket.io without falling back to polling

TIMED OUT: /hello world/



undefined

  735 |
  736 |   if (hardError) {
> 737 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  738 |   }
  739 |   return false
  740 | }

  at check (lib/next-test-utils.ts:737:11)
  at Object.<anonymous> (e2e/socket-io/index.test.js:31:5)

Read more about building and testing Next.js in contributing.md.

[gaojude]

Should we add a test to prevent regression like this?

[huozhi]

Should we add a test to prevent regression like this?

ideally yes but there might be too many pure styling issues could cause this issue. It's inifinite hole to assert all the styling. We do have a missing html error development test checking the DOM, the error itself rendering is covered. Mostly like not displayed visually

[ztanner]

was this an accident?

[devjiwonchoi]

There are some comments from us passing to the client, I'll follow up removing them (via util function, so we can still write comments without escaping like this PR did) while minifying CSS!
x-ref: NDX-750

[devjiwonchoi]

Should we add a test to prevent regression like this?

I'll find a way to prevent regression, something similar to isVisible().