[DevOverlay]: render indicator in pages router

[ztanner]

We weren't rendering the new indicator when used in pages router -- isMounted was only true when there was an error. This PR keeps the isMounted logic for the old overlay but removes it for the new one.

[ztanner]

• [DevOverlay]: enable by default #75882
• [DevOverlay]: render indicator in pages router #75918 👈 (View in Graphite)
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
buildDuration	26.8s	24s	N/A
buildDurationCached	22.7s	19.9s	N/A
nodeModulesSize	393 MB	393 MB	N/A
nextStartRea..uration (ms)	675ms	506ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
5306-HASH.js gzip	54.8 kB	54.8 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.46 kB	5.46 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	245 B	245 B	✓
main-HASH.js gzip	34.6 kB	34.5 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	245 B	245 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.59 kB	4.58 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.35 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
_buildManifest.js gzip	748 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
index.html gzip	524 B	524 B	✓
link.html gzip	540 B	537 B	N/A
withRouter.html gzip	521 B	520 B	N/A
Overall change	524 B	524 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
edge-ssr.js gzip	130 kB	130 kB	N/A
page.js gzip	211 kB	211 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
middleware-b..fest.js gzip	674 B	672 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31.3 kB	31.3 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
app-page-exp...dev.js gzip	394 kB	394 kB	✓
app-page-exp..prod.js gzip	132 kB	132 kB	✓
app-page-tur..prod.js gzip	145 kB	145 kB	✓
app-page-tur..prod.js gzip	141 kB	141 kB	✓
app-page.run...dev.js gzip	381 kB	381 kB	✓
app-page.run..prod.js gzip	129 kB	129 kB	✓
app-route-ex...dev.js gzip	39.3 kB	39.3 kB	✓
app-route-ex..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.6 kB	25.6 kB	✓
app-route-tu..prod.js gzip	25.4 kB	25.4 kB	✓
app-route.ru...dev.js gzip	40.9 kB	40.9 kB	✓
app-route.ru..prod.js gzip	25.4 kB	25.4 kB	✓
dist_client_...dev.js gzip	356 B	356 B	✓
dist_client_...dev.js gzip	349 B	349 B	✓
pages-api-tu..prod.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru...dev.js gzip	11.8 kB	11.8 kB	✓
pages-api.ru..prod.js gzip	9.68 kB	9.68 kB	✓
pages-turbo...prod.js gzip	21.9 kB	21.9 kB	✓
pages.runtim...dev.js gzip	31.5 kB	31.5 kB	✓
pages.runtim..prod.js gzip	21.9 kB	21.9 kB	✓
server.runti..prod.js gzip	61 kB	61 kB	✓
Overall change	1.67 MB	1.67 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 02-11-_devoverlay_render_indicator_in_pages_router	Change
0.pack gzip	2.11 MB	2.11 MB	⚠️ +1.48 kB
index.pack gzip	75.9 kB	76.2 kB	⚠️ +259 B
Overall change	2.18 MB	2.19 MB	⚠️ +1.74 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: 895b418

[ijjk]

Tests Passed