-
Notifications
You must be signed in to change notification settings - Fork 27.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turbopack: codegen EsmAssetReference without turbo tasks #76024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
buildDuration | 24.5s | 25.9s | |
buildDurationCached | 23.5s | 19.6s | N/A |
nodeModulesSize | 393 MB | 393 MB | ✓ |
nextStartRea..uration (ms) | 594ms | 763ms |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
5306-HASH.js gzip | 55.3 kB | 55.3 kB | N/A |
7048.HASH.js gzip | 168 B | 168 B | ✓ |
8377-HASH.js gzip | 5.46 kB | 5.46 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | ✓ |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 245 B | 245 B | ✓ |
main-HASH.js gzip | 34.9 kB | 34.9 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | ✓ |
Overall change | 55.1 kB | 55.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 194 B | ✓ |
_error-HASH.js gzip | 193 B | 192 B | N/A |
amp-HASH.js gzip | 513 B | 511 B | N/A |
css-HASH.js gzip | 342 B | 342 B | ✓ |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | N/A |
edge-ssr-HASH.js gzip | 265 B | 264 B | N/A |
head-HASH.js gzip | 363 B | 360 B | N/A |
hooks-HASH.js gzip | 393 B | 390 B | N/A |
image-HASH.js gzip | 4.59 kB | 4.59 kB | N/A |
index-HASH.js gzip | 268 B | 266 B | N/A |
link-HASH.js gzip | 2.35 kB | 2.35 kB | ✓ |
routerDirect..HASH.js gzip | 327 B | 326 B | N/A |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 325 B | 325 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.72 kB | 3.72 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 747 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
index.html gzip | 522 B | 522 B | ✓ |
link.html gzip | 538 B | 536 B | N/A |
withRouter.html gzip | 519 B | 518 B | N/A |
Overall change | 522 B | 522 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
edge-ssr.js gzip | 130 kB | 130 kB | N/A |
page.js gzip | 211 kB | 211 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 676 B | 676 B | ✓ |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.4 kB | 31.4 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 1.52 kB | 1.52 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 395 kB | 395 kB | ✓ |
app-page-exp..prod.js gzip | 133 kB | 133 kB | ✓ |
app-page-tur..prod.js gzip | 145 kB | 145 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page.run...dev.js gzip | 384 kB | 384 kB | ✓ |
app-page.run..prod.js gzip | 129 kB | 129 kB | ✓ |
app-route-ex...dev.js gzip | 39.4 kB | 39.4 kB | ✓ |
app-route-ex..prod.js gzip | 25.7 kB | 25.7 kB | ✓ |
app-route-tu..prod.js gzip | 25.7 kB | 25.7 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route.ru...dev.js gzip | 39.1 kB | 39.1 kB | ✓ |
app-route.ru..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
dist_client_...dev.js gzip | 356 B | 356 B | ✓ |
dist_client_...dev.js gzip | 349 B | 349 B | ✓ |
pages-api-tu..prod.js gzip | 9.72 kB | 9.72 kB | ✓ |
pages-api.ru...dev.js gzip | 11.8 kB | 11.8 kB | ✓ |
pages-api.ru..prod.js gzip | 9.72 kB | 9.72 kB | ✓ |
pages-turbo...prod.js gzip | 22 kB | 22 kB | ✓ |
pages.runtim...dev.js gzip | 31.6 kB | 31.6 kB | ✓ |
pages.runtim..prod.js gzip | 22 kB | 22 kB | ✓ |
server.runti..prod.js gzip | 61.2 kB | 61.2 kB | ✓ |
Overall change | 1.68 MB | 1.68 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js mischnic/codegen-esm-asset | Change | |
---|---|---|---|
0.pack gzip | 2.12 MB | 2.12 MB | |
index.pack gzip | 75.5 kB | 76.3 kB | |
Overall change | 2.19 MB | 2.19 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
441be0a
to
c14bc15
Compare
d26d227
to
f620345
Compare
c14bc15
to
c1b5810
Compare
afa87aa
to
7995fc0
Compare
7995fc0
to
6d5d578
Compare
363c994
to
00c71f6
Compare
sokra
reviewed
Feb 15, 2025
a6d73e1
to
5b6a0f4
Compare
sokra
approved these changes
Feb 17, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
EsmAssetReference::code_generation
without cells/turbo tasks.Closes PACK-3977