Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] handle ssrd nextjs internal errors in overlay #76124

Merged
merged 6 commits into from
Feb 18, 2025
+47 −3
Merged

[dev-overlay] handle ssrd nextjs internal errors in overlay #76124

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0651488
fix: handle ssrd nextjs internal errors in overlay
huozhi Feb 17, 2025
ef39883
update boring snapshot
huozhi Feb 17, 2025
1a547c6
update boring snapshot
huozhi Feb 17, 2025
ac5e76c
no console error
huozhi Feb 17, 2025
9742a97
assert specific error
huozhi Feb 17, 2025
533e5f3
assert only one log
huozhi Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/development/app-dir/ssr-only-error/ssr-only-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,14 @@ describe('ssr-only-error', () => {
const text = await browser.elementByCss('body').text()
expect(text).toBe('404\nThis page could not be found.')

// Assert if there's no console.error related to the notFound error
// Since there's already one error log containing "404" from browser:
// "Failed to load resource: the server responded with a status of 404 (Not Found)"
// We assert there's no error text in the error log
expect(await browser.log()).not.toContainEqual(
expect.objectContaining({
source: 'error',
message: expect.stringContaining('NEXT_HTTP_ERROR_FALLBACK;404'),
})
)
})
Expand Down
Loading