-
Notifications
You must be signed in to change notification settings - Fork 30k
run config deprecation checks only on user-provided configuration #82613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ztanner
merged 2 commits into
canary
from
08-13-run_config_deprecation_checks_only_on_user-provided_configuration
Aug 13, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
test/e2e/deprecation-warnings/deprecation-warnings.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { nextTestSetup } from 'e2e-utils' | ||
| import path from 'path' | ||
|
|
||
| describe('deprecation-warnings', () => { | ||
| describe('without next.config.js', () => { | ||
| const { next } = nextTestSetup({ | ||
| files: path.join(__dirname, 'fixtures/no-config'), | ||
| skipStart: true, | ||
| }) | ||
|
|
||
| it('should not emit any deprecation warnings when no config file exists', async () => { | ||
| await next.start() | ||
|
|
||
| const logs = next.cliOutput | ||
| expect(logs).not.toContain('deprecated') | ||
| expect(logs).not.toContain('has been renamed') | ||
| expect(logs).not.toContain('no longer needed') | ||
| }) | ||
| }) | ||
|
|
||
| describe('with deprecated config options', () => { | ||
| const { next } = nextTestSetup({ | ||
| files: path.join(__dirname, 'fixtures/with-deprecated-config'), | ||
| skipStart: true, | ||
| }) | ||
|
|
||
| it('should emit deprecation warnings for explicitly configured deprecated options', async () => { | ||
| await next.start() | ||
|
|
||
| const logs = next.cliOutput | ||
|
|
||
| // Should warn about amp configuration | ||
| expect(logs).toContain('Built-in amp support is deprecated') | ||
|
|
||
| // Should warn about experimental.instrumentationHook | ||
| expect(logs).toContain('experimental.instrumentationHook') | ||
| expect(logs).toContain('no longer needed') | ||
| }) | ||
| }) | ||
| }) |
11 changes: 11 additions & 0 deletions
11
test/e2e/deprecation-warnings/fixtures/no-config/app/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| export default function RootLayout({ | ||
| children, | ||
| }: { | ||
| children: React.ReactNode | ||
| }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body>{children}</body> | ||
| </html> | ||
| ) | ||
| } |
3 changes: 3 additions & 0 deletions
3
test/e2e/deprecation-warnings/fixtures/no-config/app/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Page() { | ||
| return <div>Hello World</div> | ||
| } |
11 changes: 11 additions & 0 deletions
11
test/e2e/deprecation-warnings/fixtures/with-deprecated-config/app/layout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| export default function RootLayout({ | ||
| children, | ||
| }: { | ||
| children: React.ReactNode | ||
| }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body>{children}</body> | ||
| </html> | ||
| ) | ||
| } |
3 changes: 3 additions & 0 deletions
3
test/e2e/deprecation-warnings/fixtures/with-deprecated-config/app/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Page() { | ||
| return <div>Hello World</div> | ||
| } |
9 changes: 9 additions & 0 deletions
9
test/e2e/deprecation-warnings/fixtures/with-deprecated-config/next.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| module.exports = { | ||
| // Explicitly configure deprecated options | ||
| amp: { | ||
| canonicalBase: 'https://example.com', | ||
| }, | ||
| experimental: { | ||
| instrumentationHook: true, | ||
| }, | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.