Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build feedback with dots indicating activity #8382

Merged
merged 10 commits into from
Sep 16, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 15, 2019

Replaces tty-aware-progress with ora for TTYs with fallback to normal logs for non-TTYs and adds dots spinners when doing potentially long running processes (production build, analyzing/prerendering).

Kapture 2019-08-15 at 15 47 19

Updated Preview
Kapture 2019-08-15 at 16 19 38

@ijjk
Copy link
Member Author

ijjk commented Aug 15, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 23.1s 23.7s ⚠️ +603ms
nodeModulesSize 41.3 MB 41.2 MB -73.1 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 13.8 kB 13.8 kB
main-HASH.js gzip 4.87 kB 4.87 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
commons.HASH.js 194 kB 194 kB
commons.HASH.js gzip 63.1 kB 63.1 kB
Overall change
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 11.4 kB 11.4 kB
main-HASH.module.js gzip 4.3 kB 4.3 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
commons.HASH.module.js 176 kB 176 kB
commons.HASH.module.js gzip 57.2 kB 57.2 kB
Overall change
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.9 kB 1.9 kB
_app.js gzip 905 B 905 B
_error.js 8.02 kB 8.02 kB
_error.js gzip 3.12 kB 3.12 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 4.07 kB 4.07 kB
link.js gzip 1.79 kB 1.79 kB
routerDirect.js 423 B 423 B
routerDirect.js gzip 290 B 290 B
withRouter.js 435 B 435 B
withRouter.js gzip 286 B 287 B ⚠️ +1 B
Overall change
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.79 kB 1.79 kB
_app.module.js gzip 865 B 865 B
_error.module.js 5.82 kB 5.82 kB
_error.module.js gzip 2.33 kB 2.33 kB
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 3.78 kB 3.78 kB
link.module.js gzip 1.7 kB 1.7 kB ⚠️ +1 B
routerDirect.module.js 411 B 411 B
routerDirect.module.js gzip 291 B 291 B
withRouter.module.js 423 B 423 B
withRouter.module.js gzip 288 B 288 B
Overall change
Fetched pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
link 2.8 kB 2.8 kB
link gzip 845 B 849 B ⚠️ +4 B
index 2.75 kB 2.75 kB
index gzip 840 B 841 B ⚠️ +1 B
withRouter 2.81 kB 2.81 kB
withRouter gzip 834 B 838 B ⚠️ +4 B
Overall change

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 24.4s 24.8s ⚠️ +340ms
nodeModulesSize 41.3 MB 41.2 MB -73.1 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 13.8 kB 13.8 kB
main-HASH.js gzip 4.87 kB 4.87 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
commons.HASH.js 194 kB 194 kB
commons.HASH.js gzip 63.1 kB 63.1 kB
Overall change
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 11.4 kB 11.4 kB
main-HASH.module.js gzip 4.3 kB 4.3 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
commons.HASH.module.js 176 kB 176 kB
commons.HASH.module.js gzip 57.2 kB 57.2 kB
Overall change
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.9 kB 1.9 kB
_app.js gzip 905 B 905 B
_error.js 8.02 kB 8.02 kB
_error.js gzip 3.12 kB 3.12 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 4.07 kB 4.07 kB
link.js gzip 1.79 kB 1.79 kB
routerDirect.js 423 B 423 B
routerDirect.js gzip 290 B 290 B
withRouter.js 435 B 435 B
withRouter.js gzip 287 B 287 B
Overall change
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.79 kB 1.79 kB
_app.module.js gzip 865 B 865 B
_error.module.js 5.82 kB 5.82 kB
_error.module.js gzip 2.33 kB 2.33 kB
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 3.78 kB 3.78 kB
link.module.js gzip 1.7 kB 1.7 kB
routerDirect.module.js 411 B 411 B
routerDirect.module.js gzip 291 B 291 B
withRouter.module.js 423 B 423 B
withRouter.module.js gzip 288 B 288 B
Overall change
Serverless bundles
zeit/next.js canary ijjk/next.js update-build-feedback Change
_error.js 247 kB 247 kB
_error.js gzip 66.2 kB 66.2 kB ⚠️ +1 B
index.js 247 kB 247 kB
index.js gzip 66.6 kB 66.6 kB
link.js 255 kB 255 kB
link.js gzip 68.7 kB 68.7 kB
routerDirect.js 248 kB 248 kB
routerDirect.js gzip 66.5 kB 66.5 kB
withRouter.js 248 kB 248 kB
withRouter.js gzip 66.6 kB 66.6 kB
Overall change

@ijjk
Copy link
Member Author

ijjk commented Aug 15, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 23.1s 22.7s -454ms
nodeModulesSize 41.2 MB 41.2 MB -73.5 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 13.8 kB 13.8 kB
main-HASH.js gzip 4.87 kB 4.87 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
commons.HASH.js 194 kB 194 kB
commons.HASH.js gzip 63.1 kB 63.1 kB
Overall change
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 11.4 kB 11.4 kB
main-HASH.module.js gzip 4.3 kB 4.3 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
commons.HASH.module.js 176 kB 176 kB
commons.HASH.module.js gzip 57.2 kB 57.2 kB
Overall change
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.9 kB 1.9 kB
_app.js gzip 905 B 905 B
_error.js 8.02 kB 8.02 kB
_error.js gzip 3.12 kB 3.12 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 4.04 kB 4.04 kB
link.js gzip 1.79 kB 1.79 kB
routerDirect.js 429 B 429 B
routerDirect.js gzip 293 B 292 B -1 B
withRouter.js 439 B 439 B
withRouter.js gzip 290 B 290 B
Overall change
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.79 kB 1.79 kB
_app.module.js gzip 865 B 865 B
_error.module.js 5.82 kB 5.82 kB
_error.module.js gzip 2.33 kB 2.33 kB
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 3.75 kB 3.75 kB
link.module.js gzip 1.7 kB 1.7 kB
routerDirect.module.js 417 B 417 B
routerDirect.module.js gzip 293 B 292 B -1 B
withRouter.module.js 427 B 427 B
withRouter.module.js gzip 292 B 291 B -1 B
Overall change
Fetched pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
link 2.8 kB 2.8 kB
link gzip 848 B 846 B -2 B
index 2.75 kB 2.75 kB
index gzip 841 B 840 B -1 B
withRouter 2.81 kB 2.81 kB
withRouter gzip 837 B 834 B -3 B
Overall change

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 24.5s 24.8s ⚠️ +234ms
nodeModulesSize 41.2 MB 41.2 MB -73.5 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 13.8 kB 13.8 kB
main-HASH.js gzip 4.87 kB 4.87 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
commons.HASH.js 194 kB 194 kB
commons.HASH.js gzip 63.1 kB 63.1 kB
Overall change
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 11.4 kB 11.4 kB
main-HASH.module.js gzip 4.3 kB 4.3 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH.module.js gzip 746 B 746 B
commons.HASH.module.js 176 kB 176 kB
commons.HASH.module.js gzip 57.2 kB 57.2 kB
Overall change
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.9 kB 1.9 kB
_app.js gzip 905 B 905 B
_error.js 8.02 kB 8.02 kB
_error.js gzip 3.12 kB 3.12 kB
index.js 343 B 343 B
index.js gzip 237 B 237 B
link.js 4.04 kB 4.04 kB
link.js gzip 1.79 kB 1.79 kB
routerDirect.js 429 B 429 B
routerDirect.js gzip 293 B 292 B -1 B
withRouter.js 439 B 439 B
withRouter.js gzip 290 B 290 B
Overall change
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.79 kB 1.79 kB
_app.module.js gzip 865 B 865 B
_error.module.js 5.82 kB 5.82 kB
_error.module.js gzip 2.33 kB 2.33 kB
index.module.js 319 B 319 B
index.module.js gzip 238 B 238 B
link.module.js 3.75 kB 3.75 kB
link.module.js gzip 1.7 kB 1.7 kB
routerDirect.module.js 417 B 417 B
routerDirect.module.js gzip 293 B 292 B -1 B
withRouter.module.js 427 B 427 B
withRouter.module.js gzip 292 B 291 B -1 B
Overall change
Serverless bundles
zeit/next.js canary ijjk/next.js update-build-feedback Change
_error.js 247 kB 247 kB
_error.js gzip 66.2 kB 66.3 kB ⚠️ +2 B
index.js 247 kB 247 kB
index.js gzip 66.6 kB 66.6 kB ⚠️ +2 B
link.js 255 kB 255 kB
link.js gzip 68.7 kB 68.7 kB ⚠️ +3 B
routerDirect.js 248 kB 248 kB
routerDirect.js gzip 66.5 kB 66.5 kB ⚠️ +2 B
withRouter.js 248 kB 248 kB
withRouter.js gzip 66.6 kB 66.6 kB ⚠️ +2 B
Overall change

@Timer Timer added this to the 9.0.5 milestone Aug 19, 2019
@Timer Timer modified the milestones: 9.0.5, 9.0.6 Aug 24, 2019
@Timer Timer modified the milestones: 9.0.6, 9.0.x Sep 11, 2019
@timneutkens
Copy link
Member

I'd rather not introduce a new dependency just for this.

@Timer
Copy link
Member

Timer commented Sep 15, 2019

It was swapped with another dependency of nearly equivalent size.

@ijjk
Copy link
Member Author

ijjk commented Sep 16, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 16.1s 15.3s -712ms
nodeModulesSize 42 MB 41.9 MB -83 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.66 kB 6.66 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.4 kB 6.4 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js update-build-feedback Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js update-build-feedback Change
index.html 3.62 kB 3.62 kB
index.html gzip 946 B 946 B
link.html 3.66 kB 3.66 kB
link.html gzip 953 B 953 B
withRouter.html 3.67 kB 3.67 kB
withRouter.html gzip 941 B 941 B
Overall change 10.9 kB 10.9 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary ijjk/next.js update-build-feedback Change
buildDuration 15.8s 16s ⚠️ +242ms
nodeModulesSize 42 MB 41.9 MB -83 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.js 18.2 kB 18.2 kB
main-HASH.js gzip 6.66 kB 6.66 kB
webpack-HASH.js 1.53 kB 1.53 kB
webpack-HASH.js gzip 746 B 746 B
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB
framework.5b..dbaff70d3.js 125 kB 125 kB
framework.5b..70d3.js gzip 39.4 kB 39.4 kB
Overall change 210 kB 210 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
main-HASH.module.js 16.6 kB 16.6 kB
main-HASH.module.js gzip 6.4 kB 6.4 kB
webpack-HASH.module.js 1.53 kB 1.53 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB
framework.5b..d3.module.js 125 kB 125 kB
framework.5b..dule.js gzip 39.4 kB 39.4 kB
Overall change 189 kB 189 kB
Client Pages
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.js 1.81 kB 1.81 kB
_app.js gzip 873 B 873 B
_error.js 12 kB 12 kB
_error.js gzip 4.73 kB 4.73 kB
hooks.js 12.7 kB 12.7 kB
hooks.js gzip 4.79 kB 4.79 kB
index.js 318 B 318 B
index.js gzip 222 B 222 B
link.js 8.14 kB 8.14 kB
link.js gzip 3.5 kB 3.5 kB
routerDirect.js 408 B 408 B
routerDirect.js gzip 281 B 281 B
withRouter.js 419 B 419 B
withRouter.js gzip 280 B 280 B
Overall change 35.8 kB 35.8 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js update-build-feedback Change
_app.module.js 1.7 kB 1.7 kB
_app.module.js gzip 832 B 832 B
_error.module.js 23.3 kB 23.3 kB
_error.module.js gzip 8.59 kB 8.59 kB
hooks.module.js 1.52 kB 1.52 kB
hooks.module.js gzip 793 B 793 B
index.module.js 294 B 294 B
index.module.js gzip 223 B 223 B
link.module.js 8.53 kB 8.53 kB
link.module.js gzip 3.68 kB 3.68 kB
routerDirect.module.js 394 B 394 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.module.js 404 B 404 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 36.1 kB 36.1 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js update-build-feedback Change
_buildManifest.js 81 B 81 B
_buildManifest.js gzip 61 B 61 B
_buildManifest.module.js 81 B 81 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 162 B 162 B
Serverless bundles
zeit/next.js canary ijjk/next.js update-build-feedback Change
_error.js 248 kB 248 kB
_error.js gzip 66.2 kB 66.2 kB
hooks.html 3.75 kB 3.75 kB
hooks.html gzip 978 B 978 B
index.js 248 kB 248 kB
index.js gzip 66.5 kB 66.5 kB
link.js 256 kB 256 kB
link.js gzip 68.5 kB 68.5 kB
routerDirect.js 249 kB 249 kB
routerDirect.js gzip 66.5 kB 66.5 kB
withRouter.js 249 kB 249 kB
withRouter.js gzip 66.6 kB 66.6 kB
Overall change 1.25 MB 1.25 MB

Commit: bb3567e

@timneutkens timneutkens modified the milestones: 9.0.x, 9.0.6 Sep 16, 2019
@timneutkens timneutkens merged commit 204028d into vercel:canary Sep 16, 2019
@ijjk ijjk deleted the update-build-feedback branch September 16, 2019 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants