[cache components]: guard against setCacheStatus since its conditionally defined #85125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ijjk
approved these changes
Oct 20, 2025
ztanner
deleted the
10-20-_cache_components_guard_against_setcachestatus_since_its_conditionally_defined
branch
eps1lon
reviewed
Oct 20, 2025
| // in case a previous render bypassed the cache. | ||
| if (process.env.NODE_ENV === 'development') { | ||
| setCacheStatus!('ready', htmlRequestId, requestId) | ||
| if (process.env.NODE_ENV === 'development' && setCacheStatus) { |
There was a problem hiding this comment.
Seems like a bug. How do you hit this branch with setCacheStatus not being defined?
There was a problem hiding this comment.
I added to every branch so I didn't have to think about if it was safe to unconditionally invoke, but the real one that was wrong was the bypass case on line 1908 which was only gated on bypassCachesInDev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.