Fix validate use server in pages router #85282
Closed
+274
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation in getPagesPageStaticInfo to throw error when 'use server' is used - Server Actions are only supported in App Router - 'use client' remains allowed in Pages Router as it only marks client boundaries - Add unit tests to verify validation behavior - Add integration tests to verify build errors and error messages
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
…rectives The PARSE_PATTERN regex is used as an optimization to skip parsing files that don't contain certain keywords. Without including 'use\s' in the pattern, files with only 'use server' or 'use client' directives (and no other keywords like getStaticProps, export const, etc.) would return early and skip AST parsing. This meant the 'use server' validation would never run for these files, silently allowing the invalid directive through. Changes: - Add 'use\s' to PARSE_PATTERN to match 'use server' and 'use client' - The \s (whitespace) requirement prevents false matches on variable names like useState, useEffect, or useServer - Add test to verify validation works for files with only directives - Add test to verify no false positives on React hooks and 'use' variables
|
This wouldn't work for nested components, right? or? I think |
|
@icyJoseph true, I was thinking how this incident should've failed during build time. |
…endation - Document that 'use server' validation only checks page files, not nested components - Recommend using 'import server-only' for comprehensive protection across all components - Add comment explaining PARSE_PATTERN regex and why it includes 'use\s'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a developer used
"use server"directive in a Pages Router file, the build did not fail despite it being unsupported. This could lead to runtime errors when importing APIs fromdistthat are gated behind thecacheComponentsflag, since Server Actions are only supported in the App Router.