Turbopack: disable tree shaking for tracing #85722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tests Passed |
mischnic
force-pushed
the
mischnic/trace-external-side-effects
branch
from
c6d2160 to
fac0225
Compare
ijjk
added
created-by: Turbopack team
bgw
approved these changes
Nov 3, 2025
huozhi
pushed a commit
that referenced
this pull request
Nov 12, 2025
We had tree shaking enabled for NFT. That is incorrect however, as even unused imports (if you don't use any of the imported bindings, and the file is marked as `sideEffects: false`) are still needed at runtime, since Node.js will execute everything anyway. - I made the `treeShakingMode: None` explicit now (though that was already the `Default::default` anyway) - The real problem was that we still dropped side-effect free `ModulePart::Evaluation` references even when tree shaking was disabled. Closes #85172 Fixes PACK-5756
huozhi
pushed a commit
that referenced
this pull request
Nov 12, 2025
We had tree shaking enabled for NFT. That is incorrect however, as even unused imports (if you don't use any of the imported bindings, and the file is marked as `sideEffects: false`) are still needed at runtime, since Node.js will execute everything anyway. - I made the `treeShakingMode: None` explicit now (though that was already the `Default::default` anyway) - The real problem was that we still dropped side-effect free `ModulePart::Evaluation` references even when tree shaking was disabled. Closes #85172 Fixes PACK-5756
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had tree shaking enabled for NFT.
That is incorrect however, as even unused imports (if you don't use any of the imported bindings, and the file is marked as
sideEffects: false) are still needed at runtime, since Node.js will execute everything anyway.treeShakingMode: Noneexplicit now (though that was already theDefault::defaultanyway)ModulePart::Evaluationreferences even when tree shaking was disabled.Closes #85172
Fixes PACK-5756