Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dev deps #193

Merged
merged 2 commits into from
May 5, 2021
Merged

chore: bump dev deps #193

merged 2 commits into from
May 5, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented May 5, 2021

Seems like windows started failing in #192 so I bumped dev deps.

I also removed the test for grpc since its deprecated.

@styfle styfle requested a review from ijjk May 5, 2021 21:13
@styfle styfle requested review from lucleray and Timer as code owners May 5, 2021 21:13
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #193 (2d2b694) into main (955fe08) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   80.31%   80.24%   -0.08%     
==========================================
  Files          13       13              
  Lines        1392     1392              
  Branches      531      531              
==========================================
- Hits         1118     1117       -1     
  Misses        107      107              
- Partials      167      168       +1     
Impacted Files Coverage Δ
src/utils/binary-locators.ts 30.76% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955fe08...2d2b694. Read the comment docs.

@styfle styfle merged commit 9a72a8e into main May 5, 2021
@styfle styfle deleted the bump-grpc-deps branch May 5, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants