Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special case argon2 lib binding #195

Merged
merged 1 commit into from
May 10, 2021
Merged

fix: special case argon2 lib binding #195

merged 1 commit into from
May 10, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented May 8, 2021

Fixes #183

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #195 (7ff0b20) into main (186e49b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.01%     
==========================================
  Files          13       13              
  Lines        1392     1393       +1     
  Branches      531      531              
==========================================
+ Hits         1118     1119       +1     
  Misses        107      107              
  Partials      167      167              
Impacted Files Coverage Δ
src/utils/special-cases.ts 88.15% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186e49b...7ff0b20. Read the comment docs.

@styfle styfle requested a review from guybedford May 8, 2021 18:22
@styfle styfle marked this pull request as ready for review May 8, 2021 18:22
@styfle styfle requested review from lucleray and Timer as code owners May 8, 2021 18:22
@styfle
Copy link
Member Author

styfle commented May 8, 2021

@guybedford We might have an issue with node-pre-gyp deprecated in favor of @mapbox/node-pre-gyp

https://www.npmjs.com/package/node-pre-gyp

Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like direct support for @mapbox/node-pre-gyp would be useful then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add argon2 compatibility with vercel
2 participants