Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support webpack chunked wrappers #205

Merged
merged 2 commits into from
May 13, 2021
Merged

fix: support webpack chunked wrappers #205

merged 2 commits into from
May 13, 2021

Conversation

guybedford
Copy link
Contributor

Fixes Webpack wrapper detection to support non-parameter wrapper IIFEs and 'use strict' in external blocks.

Resolves #201.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #205 (13c54f7) into main (61aac0a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 13c54f7 differs from pull request most recent head 9710c1a. Consider uploading reports for the commit 9710c1a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   80.54%   80.58%   +0.04%     
==========================================
  Files          13       13              
  Lines        1398     1401       +3     
  Branches      534      537       +3     
==========================================
+ Hits         1126     1129       +3     
  Misses        107      107              
  Partials      165      165              
Impacted Files Coverage Δ
src/utils/wrappers.ts 73.68% <100.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61aac0a...9710c1a. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 0b4fa90 into main May 13, 2021
@styfle styfle deleted the webpack-wrapper-chunk branch May 13, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing fails to detect fs when used in multiple entries with webpack 5
2 participants