-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support @mapbox/node-pre-gyp workflows #206
Conversation
'@mapbox/node-pre-gyp': { | ||
default: mapboxPregyp, | ||
...mapboxPregyp | ||
}, | ||
'node-pre-gyp': pregyp, | ||
'node-pre-gyp/lib/pre-binding': pregyp, | ||
'node-pre-gyp/lib/pre-binding.js': pregyp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace the legacy node-pre-gyp
with the new mapbox one here or keep them both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep both for legacy compat, possibly dropping the old one in a subsequent major.
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 80.58% 80.59% +0.01%
==========================================
Files 13 13
Lines 1401 1402 +1
Branches 537 537
==========================================
+ Hits 1129 1130 +1
Misses 107 107
Partials 165 165
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again 👍
@styfle how about dropping support for EDIT: we could also get rid of |
I think we need to keep Regarding |
Resolves #199.