Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support @mapbox/node-pre-gyp workflows #206

Merged
merged 3 commits into from
May 13, 2021
Merged

feat: support @mapbox/node-pre-gyp workflows #206

merged 3 commits into from
May 13, 2021

Conversation

guybedford
Copy link
Contributor

Resolves #199.

'@mapbox/node-pre-gyp': {
default: mapboxPregyp,
...mapboxPregyp
},
'node-pre-gyp': pregyp,
'node-pre-gyp/lib/pre-binding': pregyp,
'node-pre-gyp/lib/pre-binding.js': pregyp,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace the legacy node-pre-gyp with the new mapbox one here or keep them both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep both for legacy compat, possibly dropping the old one in a subsequent major.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #206 (9f1ab32) into main (0b4fa90) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   80.58%   80.59%   +0.01%     
==========================================
  Files          13       13              
  Lines        1401     1402       +1     
  Branches      537      537              
==========================================
+ Hits         1129     1130       +1     
  Misses        107      107              
  Partials      165      165              
Impacted Files Coverage Δ
src/analyze.ts 87.71% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4fa90...9f1ab32. Read the comment docs.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again 👍

@styfle styfle enabled auto-merge (squash) May 13, 2021 14:11
@styfle styfle merged commit 24e3c7d into main May 13, 2021
@styfle styfle deleted the mapbox-pre-gyp branch May 13, 2021 14:23
@XhmikosR
Copy link

XhmikosR commented Jan 12, 2022

@styfle how about dropping support for node-pre-gyp now? It's been some time and it should get rid of the npm install warning plus reduce the package size :)

EDIT: we could also get rid of mkdirp assuming Node.js >=10.12.0

@styfle
Copy link
Member

styfle commented Jan 13, 2022

I think we need to keep node-pre-gyp since it still gets 2.7 million downloads a week and has 812 packages that depend on it. See the comment above.

Regarding mkdirp we can drop it in #260, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for @mapbox/node-pre-gyp
3 participants