Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrappers cannot read type of undefined #212

Merged
merged 1 commit into from
May 22, 2021
Merged

fix: wrappers cannot read type of undefined #212

merged 1 commit into from
May 22, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented May 22, 2021

Fixes #210

I don't have the source code to reproduce so I didn't add a test

@styfle styfle changed the title fix: wrappers type of undefined fix: wrappers cannot read type of undefined May 22, 2021
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #212 (4df7432) into main (320ff68) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          13       13           
  Lines        1402     1402           
  Branches      537      537           
=======================================
  Hits         1124     1124           
  Misses        109      109           
  Partials      169      169           
Impacted Files Coverage Δ
src/utils/wrappers.ts 73.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320ff68...4df7432. Read the comment docs.

@styfle styfle enabled auto-merge (squash) May 22, 2021 16:09
@styfle styfle merged commit fc2ec58 into main May 22, 2021
@styfle styfle deleted the fix-210 branch May 22, 2021 16:12
@benjamintd
Copy link

Thank you @styfle for taking the time to fix this during your vacation. It is greatly appreciated!

@styfle
Copy link
Member Author

styfle commented May 22, 2021

@benjamintd No problem! Can you verify the issue is fixed by adding the env var FORCE_RUNTIME_TAG=canary and deploying again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing builds on Vercel
3 participants