Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove internal types on publish #223

Merged
merged 1 commit into from
Jun 6, 2021
Merged

fix: remove internal types on publish #223

merged 1 commit into from
Jun 6, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 6, 2021

Fixes consumers using TS failing with

Error: ../../node_modules/@vercel/nft/out/types.d.ts(3,34): error TS2307: Cannot find module 'estree' or its corresponding type declarations.
Error: Command failed: tsc

This moves internal types to ./utils/types.ts and deletes those upon publishing.

The external types will continue to live in ./types.ts.

@styfle styfle requested a review from ijjk June 6, 2021 19:20
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #223 (5c5b173) into main (47f890a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          13       13           
  Lines        1433     1433           
  Branches      537      537           
=======================================
  Hits         1147     1147           
  Misses        114      114           
  Partials      172      172           
Impacted Files Coverage Δ
src/analyze.ts 86.57% <ø> (ø)
src/utils/special-cases.ts 88.60% <ø> (ø)
src/utils/static-eval.ts 82.95% <ø> (ø)
src/utils/wrappers.ts 74.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f890a...5c5b173. Read the comment docs.

@ijjk ijjk merged commit 3291219 into main Jun 6, 2021
@ijjk ijjk deleted the fix-types-on-publish branch June 6, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants