Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: private fields support #224

Merged
merged 1 commit into from
Jun 10, 2021
Merged

feat: private fields support #224

merged 1 commit into from
Jun 10, 2021

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Jun 10, 2021

Adds the acorn plugin for private fields and removes the ignored ecmascript tests.

It turns out a lot of the previously ignored tests are no longer present as well so there are currently no ignores!

Resolves: #221

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's great!

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #224 (46a6693) into main (19f6482) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          13       13           
  Lines        1433     1433           
  Branches      537      537           
=======================================
  Hits         1147     1147           
  Misses        114      114           
  Partials      172      172           
Impacted Files Coverage Δ
src/analyze.ts 86.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f6482...46a6693. Read the comment docs.

@styfle styfle enabled auto-merge (squash) June 10, 2021 14:11
@styfle styfle merged commit 5b83be5 into main Jun 10, 2021
@styfle styfle deleted the private-fields branch June 10, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

private class methods fail to parse
2 participants