-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert fs operations from sync to async #236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 80.11% 80.30% +0.19%
==========================================
Files 13 13
Lines 1438 1447 +9
Branches 538 539 +1
==========================================
+ Hits 1152 1162 +10
+ Misses 114 113 -1
Partials 172 172
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add a test for async usage too 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks! 🎉
This updates to the latest version of `node-file-trace` and leverages the new async fs handling with webpack. In a follow-up PR we will implement the async resolver to share resolving with webpack as well. x-ref: vercel/nft#236
This updates to the latest version of `node-file-trace` and leverages the new async fs handling with webpack. In a follow-up PR we will implement the async resolver to share resolving with webpack as well. x-ref: vercel/nft#236
This converts our sync fs usage to async to help with performance and to allow external
resolve
functions to be async as well. Noticed the synchronous resolving was taking a big chunk of time while tracing duringnext build
so hopefully this allows us to hook into webpack's resolver and give a good performance boost.