Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phantomjs-prebuilt binary #46

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix phantomjs-prebuilt binary #46

merged 1 commit into from
Aug 15, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 15, 2019

Fixes #44

@styfle styfle requested a review from TooTallNate August 15, 2019 03:56
@styfle styfle requested a review from lucleray as a code owner August 15, 2019 03:56
@styfle styfle added the automerge Automatically merge PR once checks pass label Aug 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #46 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   89.94%   89.96%   +0.02%     
==========================================
  Files          10       10              
  Lines         975      977       +2     
==========================================
+ Hits          877      879       +2     
  Misses         98       98
Impacted Files Coverage Δ
src/utils/special-cases.js 95.31% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80243a5...59502e4. Read the comment docs.

@kodiakhq kodiakhq bot merged commit fe8123c into master Aug 15, 2019
@kodiakhq kodiakhq bot deleted the phantomjs-prebuilt branch August 15, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phantomjs-prebuilt does not work
3 participants