Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript types #57

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Update typescript types #57

merged 3 commits into from
Aug 30, 2019

Conversation

AndyBitz
Copy link
Contributor

Updates the types for typescript.

Is required for vercel/vercel#2926

styfle
styfle reviewed Aug 30, 2019
View reviewed changes
node-file-trace.d.ts

export = NodeFileTrace;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed to default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used export = before, then linked it and typescript complained when I've tried to build a package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe esModuleInterop should take care of it (I think it supports both syntax options to export). But if it was failing in @now/next, then we can change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, it failed in @now/next

@codecov-io
Copy link

codecov-io commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          10       10           
  Lines         991      991           
=======================================
  Hits          892      892           
  Misses         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bc51a...48012cf. Read the comment docs.

@styfle styfle changed the title Update types Update typescript types Aug 30, 2019
styfle
styfle approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle added the automerge Automatically merge PR once checks pass label Aug 30, 2019
@styfle
Copy link
Member

styfle commented Aug 30, 2019 •
edited
Loading

@AndyBitz Looks good! Feel free to release (probably semver patch?) after CI passes.

@kodiakhq kodiakhq bot merged commit 768caef into master Aug 30, 2019
@kodiakhq kodiakhq bot deleted the update-types branch August 30, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@lucleray lucleray Awaiting requested review from lucleray

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndyBitz @codecov-io @styfle