Add support for 14.16.0

[david-mohr]

Updated patch for 14.16.0

Closes #117

[leerob]

Thank you!

[david-mohr]

Happy to help @leerob. Could you please kick off a build so that the new binaries are in Releases?

[bfivelson]

Hi @leerob and @david-mohr

I tried to build binaries in the mean time as the they not in the release

I am having an issue trying to build win64 binaries. This is my first time so I am sure I am doing something wrong

I have downloaded node build tools
I have checked out node v14.16.0
I have put the patch file in the the node dir and i get the following when i try to apply

git apply node.v14.16.0.cpp.patch
node.v14.16.0.cpp.patch:186: trailing whitespace.
'use strict';
node.v14.16.0.cpp.patch:187: trailing whitespace.

node.v14.16.0.cpp.patch:188: trailing whitespace.
const {
node.v14.16.0.cpp.patch:189: trailing whitespace.
prepareMainThreadExecution
node.v14.16.0.cpp.patch:190: trailing whitespace.
} = require('internal/bootstrap/pre_execution');
error: corrupt patch at line 606

I add a line return at the end of the file and now I get

git apply node.v14.16.0.cpp.patch
node.v14.16.0.cpp.patch:186: trailing whitespace.
'use strict';
node.v14.16.0.cpp.patch:187: trailing whitespace.

node.v14.16.0.cpp.patch:188: trailing whitespace.
const {
node.v14.16.0.cpp.patch:189: trailing whitespace.
prepareMainThreadExecution
node.v14.16.0.cpp.patch:190: trailing whitespace.
} = require('internal/bootstrap/pre_execution');
error: patch failed: deps/v8/include/v8.h:9525
error: deps/v8/include/v8.h: patch does not apply
error: patch failed: deps/v8/src/api/api.cc:927
error: deps/v8/src/api/api.cc: patch does not apply
error: patch failed: deps/v8/src/codegen/compiler.cc:2045
error: deps/v8/src/codegen/compiler.cc: patch does not apply
error: patch failed: deps/v8/src/objects/js-objects.cc:5524
error: deps/v8/src/objects/js-objects.cc: patch does not apply
error: patch failed: deps/v8/src/objects/shared-function-info-inl.h:493
error: deps/v8/src/objects/shared-function-info-inl.h: patch does not apply
error: patch failed: deps/v8/src/parsing/parsing.cc:42
error: deps/v8/src/parsing/parsing.cc: patch does not apply
error: patch failed: deps/v8/src/snapshot/code-serializer.cc:409
error: deps/v8/src/snapshot/code-serializer.cc: patch does not apply
error: patch failed: lib/internal/bootstrap/pre_execution.js:9
error: lib/internal/bootstrap/pre_execution.js: patch does not apply

git status
HEAD detached at v14.16.0
Untracked files:
(use "git add ..." to include in what will be committed)

    node.v14.16.0.cpp.patch

nothing added to commit but untracked files present (use "git add" to track)

What am I doing wrong?

Thank you!

[bfivelson]

I ran this command which seemed to produce a better result

git apply --reject --whitespace=fix node.v14.16.0.cpp.patch

I will try and build now

[bfivelson]

I got these errors

node_contextify.cc
node\src\node_contextify.cc(765): error C2039: 'EnableCompilationForSourcelessUse': is not a member of 'v8::V8' [node\libnode.vcxproj]
node\deps\v8\include\v8.h(9600): note: see declaration of 'v8::V8'
node\src\node_contextify.cc(765): error C3861: 'EnableCompilationForSourcelessUse': identifier not found [node\libnode.vcxproj]
node\src\node_contextify.cc(787): error C2039: 'FixSourcelessScript': is not a member of 'v8::V8' [node\libnode.vcxproj]
node\deps\v8\include\v8.h(9600): note: see declaration of 'v8::V8'
node\src\node_contextify.cc(787): error C3861: 'FixSourcelessScript': identifier not found [node\libnode.vcxproj]
node\src\node_contextify.cc(818): error C2039: 'DisableCompilationForSourcelessUse': is not a member of 'v8::V8' [node\libnode.vcxproj]
node\deps\v8\include\v8.h(9600): note: see declaration of 'v8::V8'
node\src\node_contextify.cc(818): error C3861: 'DisableCompilationForSourcelessUse': identifier not found [node\libnode.vcxproj]

[bfivelson]

moved to #122

[david-mohr]

@bfivelson have you tried using plain patch? I have successfully built windows binaries, they are in my fork as release 2.7

[bfivelson]

@david-mohr Thank you, so much for this!

I have not, where can I find information on the plain patch?

[david-mohr]

https://github.com/vercel/pkg-fetch/blob/master/lib/build.js#L38-L48

patch -p1 -i /path/to/the.patch

You should get a copy of patch on Windows when you install git-bash

[bfivelson]

@david-mohr Thank you so much for all your help with this !