Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

build: fetch Node.js sources from tar.gz archive instead of Git #225

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Nov 6, 2021

Bug: #204, #212

For #212 use case, the user may place the source archive and its .sha256sum to $PKG_CACHE_PATH/node (by default, PKG_CACHE_PATH is ~/.pkg-cache), if the network connection is restricted.

@jesec
Copy link
Contributor Author

jesec commented Nov 6, 2021

cc: @blami

Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if it could make sense to provide both ways instead of completely drop git?

@blami
Copy link

blami commented Nov 7, 2021

Thanks for heads up. I went with recommendation given in #212 and patch and pre-build my tarball outside pkg, then just provide binary in expected place so I technically don't need this nor other patch to make certain bits of Node.js shared with OS anymore. I will close my PR - forgot about it.

@robertsLando That is what my patch #212 does and @jesec didn't like it.

Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I don't want to prevent this being merged. I trust @jesec in his choice

@jesec jesec merged commit da210e4 into main Nov 7, 2021
@jesec jesec deleted the pr/tar branch November 7, 2021 17:02
@jesec
Copy link
Contributor Author

jesec commented Nov 7, 2021

The real aim of the PR is to deal with #204. I think it is better to be less reliant on the unmanaged packages on the system (in that case, git). It just happens to deal with #212 as well, with zero additional complexity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants