chore: add ci, stale workflows and dependabot #1074

robertsLando · 2021-03-23T08:57:47Z

No description provided.

robertsLando · 2021-03-23T10:47:19Z

@leerob @jesec Seems all tests work except on windows. Each test takes ~30' on linux and ~50' on macos. We should find a way to speed up them at least to less then 10 minutes

jesec · 2021-03-23T13:17:33Z

@leerob @jesec Seems all tests work except on windows. Each test takes ~30' on linux and ~50' on macos. We should find a way to speed up them at least to less then 10 minutes

Indeed. We can split tests into different groups, so we can run them on multiple machines in parallel. Or can we simply run multiple tests in parallel on one machine, as pkg seems to be a single-thread task?

robertsLando · 2021-03-23T13:43:29Z

We could use nodejs cluster module for that I think?

leerob · 2021-03-23T13:45:06Z

Let's combine efforts here #1073

robertsLando · 2021-03-23T13:48:28Z

Let's combine efforts here #1073

@leerob This adds much more and it's more complete than that

.github/dependabot.yml

.github/workflows/close-stale.yml

jesec · 2021-03-23T13:56:54Z

dictionary/.eslintrc.json

@@ -1,5 +1,8 @@
 {
  "parserOptions": {
    "sourceType": "script"
+  },
+  "rules":{
+    "linebreak-style": 0


I think this is a very important rule. It makes sure that people don't accidentally use CRLF.

Can we fix the Windows problem with other methods?

tried another approach

I have removed lint from the test command and I check linting only on one os/node version (useless to do linting on all platforms/node version)

.github/workflows/ci.yml

leerob · 2021-03-23T14:39:17Z

@leerob This adds much more and it's more complete than that

I'm fine with whatever, just mentioning we should combine efforts into a single PR!

robertsLando · 2021-03-23T15:19:22Z

@leerob @jesec Seems that tests are failing on windows, I would remove it for now and also remove macos and just keep ubuntu like it was with trevis

robertsLando · 2021-03-23T15:27:20Z

I also tried writing a script like this to speed up tests:

'use strict';

const cluster = require('cluster');
const { spawn } = require('child_process');
const path = require('path');
const os = require('os');

const args = [
    [ 'node14', 'no-npm' ],
    [ 'node12', 'no-npm' ],
    [ 'node10', 'no-npm' ],
    [ 'host', 'only-npm' ]
];

if (cluster.isMaster) {
    console.log('Parallel tests starting');

    // Fork workers.
    for (const a of args) {
        cluster.fork({ args: a.join(' ') });
    }

    cluster.on('exit', (worker) => {
        console.log(`worker ${worker.process.pid} died`);
    });
} else {
    const cache = path.join(os.homedir(), '.pkg-cache', process.env.args);
    spawn('node', [ './test/test.js', ...process.env.args.split(' ') ], {
        cwd: process.cwd(),
        env: {
            ...process.env,
            PKG_CACHE_PATH: cache
        },
        detached: true,
        stdio: 'inherit'
    });
}

The problem is I don't think some of them can be run in parallel as I'm getting different errors

robertsLando · 2021-03-24T08:05:30Z

@leerob @jesec Updates here?

jesec · 2021-03-24T08:50:49Z

dictionary/.eslintrc.json

@@ -2,4 +2,4 @@
  "parserOptions": {
    "sourceType": "script"
  }
-}
+}


Unnecessary EOF change here.

jesec · 2021-03-24T08:57:33Z

There is a minor EOF issue. And, we probably don’t want to run dependabot daily. Other than that, lg2m.

leerob · 2021-03-24T14:03:26Z

LGTM

jesec · 2021-03-24T15:13:53Z

Rebased, squashed, and made minor changes, per prior discussions:

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 3509525..b339b63 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -3,7 +3,7 @@ updates:
   - package-ecosystem: npm
     directory: '/'
     schedule:
-      interval: daily
+      interval: 'weekly'
     allow:
       - dependency-type: 'production'
     labels:
@@ -12,7 +12,7 @@ updates:
   - package-ecosystem: 'npm'
     directory: '/'
     schedule:
-      interval: 'daily'
+      interval: 'weekly'
     target-branch: master
     allow:
       - dependency-type: 'development'
@@ -23,4 +23,4 @@ updates:
   - package-ecosystem: 'github-actions'
     directory: '/'
     schedule:
-      interval: 'daily'
+      interval: 'weekly'
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 23d8a18..ad791c3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,4 +1,4 @@
-name: ci
+name: CI
 
 on:
   push:
diff --git a/.gitignore b/.gitignore
index ccea779..62ffed4 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,4 +17,5 @@ examples/express/express-example
 # Example dependencies
 examples/express/node_modules
 
-/.vscode/
+# Editors
+.vscode/
diff --git a/README.md b/README.md
index 306c5f9..7ec0012 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@
 
 ![](https://res.cloudinary.com/zeit-inc/image/upload/v1509936789/repositories/pkg/pkg-repo-banner-new.png)
 
-[![ci](https://github.com/vercel/pkg/actions/workflows/ci.yml/badge.svg)](https://github.com/vercel/pkg/actions/workflows/ci.yml)
+[![Build Status](https://github.com/vercel/pkg/actions/workflows/ci.yml/badge.svg)](https://github.com/vercel/pkg/actions/workflows/ci.yml)
 [![Coverage Status](https://coveralls.io/repos/github/vercel/pkg/badge.svg?branch=master)](https://coveralls.io/github/vercel/pkg?branch=master)
 [![Dependency Status](https://david-dm.org/vercel/pkg/status.svg)](https://david-dm.org/vercel/pkg)
 [![devDependency Status](https://david-dm.org/vercel/pkg/dev-status.svg)](https://david-dm.org/vercel/pkg?type=dev)
diff --git a/dictionary/.eslintrc.json b/dictionary/.eslintrc.json
index 39efc94..74e0826 100644
--- a/dictionary/.eslintrc.json
+++ b/dictionary/.eslintrc.json
@@ -2,4 +2,4 @@
   "parserOptions": {
     "sourceType": "script"
   }
-}
\ No newline at end of file
+}

robertsLando · 2021-03-24T16:46:57Z

@leerob Could you squash and merge this? Needs admin priviledges, also in branch protection settings you should change the required checks and remove travis from required

jesec · 2021-03-24T17:22:30Z

Ummm…. dependabot don’t know how to squash the PRs and started to spam the project. Even if all of them are promptly merged by maintainers, the commit history gets spammed.

I don’t think that’s good for the health of the project, as once in while, the automated PRs can drown more important PRs. Commit history full of automatic commits also makes it hard to write changelogs or locate more important commits.

I think we ought to figure out a different solution/configuration.

leerob · 2021-03-24T17:26:49Z

If there's an option to group PRs for Dependabot, I'm good with that.

robertsLando · 2021-03-25T08:39:33Z

We could use https://mergify.io/ to auto merge dev deps once checks pass. Thoughts?

jesec · 2021-03-25T08:58:10Z

We could use https://mergify.io/ to auto merge dev deps once checks pass. Thoughts?

Auto merging is not a good solution. Commit history still gets spammed. I prefer to configure dependabot to security-only or disable it altogether.

robertsLando · 2021-03-25T09:00:22Z

Ok no problem for me

robertsLando requested a review from jesec March 23, 2021 08:57

This was referenced Mar 23, 2021

Looking for maintainers! #1065

Closed

add workflow for GitHub Actions #1073

Closed

jesec reviewed Mar 23, 2021

View reviewed changes

jesec reviewed Mar 24, 2021

View reviewed changes

chore: add ci, stale workflows and dependabot

5f53bea

jesec force-pushed the workflows branch from e78eb7d to 5f53bea Compare March 24, 2021 15:11

jesec approved these changes Mar 24, 2021

View reviewed changes

leerob approved these changes Mar 24, 2021

View reviewed changes

leerob merged commit 31e8bf7 into master Mar 24, 2021

leerob deleted the workflows branch March 24, 2021 17:08

leerob mentioned this pull request Mar 25, 2021

Switch to GitHub Actions #1071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add ci, stale workflows and dependabot #1074

chore: add ci, stale workflows and dependabot #1074

robertsLando commented Mar 23, 2021

robertsLando commented Mar 23, 2021

jesec commented Mar 23, 2021

robertsLando commented Mar 23, 2021

leerob commented Mar 23, 2021

robertsLando commented Mar 23, 2021

jesec Mar 23, 2021

robertsLando Mar 23, 2021

robertsLando Mar 23, 2021

leerob commented Mar 23, 2021

robertsLando commented Mar 23, 2021

robertsLando commented Mar 23, 2021 •

edited

Loading

robertsLando commented Mar 24, 2021

jesec Mar 24, 2021

jesec commented Mar 24, 2021

leerob commented Mar 24, 2021

jesec commented Mar 24, 2021

robertsLando commented Mar 24, 2021

jesec commented Mar 24, 2021

leerob commented Mar 24, 2021

robertsLando commented Mar 25, 2021

jesec commented Mar 25, 2021

robertsLando commented Mar 25, 2021

chore: add ci, stale workflows and dependabot #1074

chore: add ci, stale workflows and dependabot #1074

Conversation

robertsLando commented Mar 23, 2021

robertsLando commented Mar 23, 2021

jesec commented Mar 23, 2021

robertsLando commented Mar 23, 2021

leerob commented Mar 23, 2021

robertsLando commented Mar 23, 2021

jesec Mar 23, 2021

Choose a reason for hiding this comment

robertsLando Mar 23, 2021

Choose a reason for hiding this comment

robertsLando Mar 23, 2021

Choose a reason for hiding this comment

leerob commented Mar 23, 2021

robertsLando commented Mar 23, 2021

robertsLando commented Mar 23, 2021 • edited Loading

robertsLando commented Mar 24, 2021

jesec Mar 24, 2021

Choose a reason for hiding this comment

jesec commented Mar 24, 2021

leerob commented Mar 24, 2021

jesec commented Mar 24, 2021

robertsLando commented Mar 24, 2021

jesec commented Mar 24, 2021

leerob commented Mar 24, 2021

robertsLando commented Mar 25, 2021

jesec commented Mar 25, 2021

robertsLando commented Mar 25, 2021

robertsLando commented Mar 23, 2021 •

edited

Loading