Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Skip pnpm tests when nodeversion is < 12 #1122

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Skip pnpm tests when nodeversion is < 12 #1122

merged 1 commit into from
Apr 7, 2021

Conversation

erossignon
Copy link
Contributor

No description provided.

@erossignon erossignon mentioned this pull request Apr 7, 2021
Merged
@erossignon erossignon mentioned this pull request Apr 7, 2021
Merged
robertsLando
robertsLando approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future we could also check supported nodejs versions in package.json and skip tests automatically if not there. BTW LGTM for now

@robertsLando robertsLando changed the title skip pnpm tests when nodeversion is < 12 Skip pnpm tests when nodeversion is < 12 Apr 7, 2021
@robertsLando robertsLando merged commit 3507e2c into vercel:master Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erossignon @robertsLando