Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

fix: fs readdir and readdirSync (#1130/#1299) #1495

Merged
merged 12 commits into from
Feb 1, 2022
Merged

fix: fs readdir and readdirSync (#1130/#1299) #1495

merged 12 commits into from
Feb 1, 2022

Conversation

kldzj
Copy link
Contributor

@kldzj kldzj commented Jan 30, 2022

This pull request is addressing issue #1130 and is a continuation of the seemingly stale and unmergable #1299.

@kldzj kldzj marked this pull request as draft January 31, 2022 01:01
@kldzj
Copy link
Contributor Author

kldzj commented Jan 31, 2022

There was a regression regarding #938 without the latest commit (d781d7b), for which I've included the needed changes and an test. The PR is now ready to be checked.

@kldzj kldzj marked this pull request as ready for review January 31, 2022 09:53
@john-u
Copy link

john-u commented Feb 1, 2022

Similar to #1299 (comment), I've pulled and linked this PR locally and confirmed it resolves our issue.

@jesec jesec merged commit 5010411 into vercel:main Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants