Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

fix: add force flag to codesign to avoid already signed error #1756

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

brianunlam
Copy link
Contributor

It adds force flag to codesign utility to avoid errors when an existing sign prevents a new sign.
It solves #1574

@robertsLando robertsLando changed the title Fix: Add force flag to codesign to avoid already signed error fix: add force flag to codesign to avoid already signed error Sep 14, 2022
@lattwood
Copy link

Hey, anything I can do to help get this merged in?

@robertsLando
Copy link
Contributor

I would like to know @jesec opinion about this as he has more experience then me regarding mac OS things, dunno if that flag could break older OS?

@bro4all
Copy link

bro4all commented Oct 13, 2022

The flag is just a force flag, it is very old and compatible with other os

@134130
Copy link

134130 commented Nov 6, 2022

The flag is compatible and It doesn't take any wrong effects.

When signing, causes codesign to replace any existing signature on the path(s) given.
Without this option, existing signatures will not be replaced, and the signing operation fails.
from man codesign :D

@robertsLando
Copy link
Contributor

@jesec ping

@ryanblock
Copy link

Bump

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Mar 1, 2023
@ryanblock
Copy link

@jesec bump again

@robertsLando robertsLando enabled auto-merge (squash) March 1, 2023 08:55
@github-actions github-actions bot removed the Stale label Mar 2, 2023
@ryanblock
Copy link

FYI @robertsLando seems like the failed run is a non issue.

@robertsLando robertsLando changed the title fix: add force flag to codesign to avoid already signed error Add force flag to codesign to avoid already signed error Mar 2, 2023
@robertsLando robertsLando enabled auto-merge (squash) March 2, 2023 16:23
@robertsLando robertsLando changed the title Add force flag to codesign to avoid already signed error fix: add force flag to codesign to avoid already signed error Mar 2, 2023
@robertsLando robertsLando enabled auto-merge (squash) March 2, 2023 16:23
@134130
Copy link

134130 commented Mar 6, 2023

@brianunlam @robertsLando
The auto-merge is not available since node16's prettier is failing.
The prettier is warning 'print-width' is over.

Would you resolve this issue? I don't have any permission to commit this.
Simple command: prettier -w lib/mach-o.ts

@robertsLando robertsLando merged commit f19285d into vercel:main Mar 6, 2023
@Mikescops
Copy link
Contributor

@robertsLando can a release version be tagged with this change?

@robertsLando
Copy link
Contributor

@Mikescops Need to speak with @leerob and @baparham about that

pcnate pushed a commit to pcnate/pkg that referenced this pull request Aug 15, 2023
…#1756)

Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants