Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Ignore pnpm test for node14 #1919

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Ignore pnpm test for node14 #1919

merged 2 commits into from
Apr 28, 2023

Conversation

emmansun
Copy link
Contributor

according error message of the actions and pnpm/pnpm#6297

according error message of the actions and pnpm/pnpm#6297
test/utils.js Show resolved Hide resolved
@emmansun
Copy link
Contributor Author

ok, close first.

@emmansun emmansun closed this Apr 21, 2023
@emmansun emmansun reopened this Apr 21, 2023
@justajwolf
Copy link

@baparham this pr is ok,you think?

Copy link
Contributor

@baparham baparham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I approved the workflow to run also, so if that passes this should be good to merge

@justajwolf
Copy link

@emmansun It is time to merge this pr.

@baparham
Copy link
Contributor

@emmansun It is time to merge this pr.

I believe the controls are setup so that it's on us to do that, but yes, time to merge.

@baparham baparham merged commit 7255f64 into vercel:main Apr 28, 2023
pcnate pushed a commit to pcnate/pkg that referenced this pull request Aug 15, 2023
* Ignore pnpm test for node14

according error message of the actions and pnpm/pnpm#6297

* trigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants