-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(middleware): improve readability by modularizing logic and adding documentation #397
base: main
Are you sure you want to change the base?
Conversation
joelybahh
commented
Mar 30, 2024
- Broke down the middleware into smaller, more descriptive functions.
- Added documentation to each function, explaining its purpose and usage.
- Streamlined the code to enhance its readability, making the template more accessible to developers of varying skill levels.
…dding documentation
@joelybahh is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
you are awesome@joelybahh you are incredible! this refactor was so helpful to me. could you help again?I have launched this multi-tenant app successfully on vercel and I have several custom domains. It works locally great as well. My only issue is I cannot currently get it to work with production for cell generated domains or vercel generated preview domains. |
i believe the problem is going to be occurring here in the code:
|
I am actually wondering if vercel changed their construction of deployment suffixes... i have also upgraded to a paid account and wonder if maybe paid accounts have a different construction for deployment suffixes and hostname construction. |