Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playground): update resvg-wasm #383

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Feb 2, 2023

  • updates resvg-wasm
  • uses wasm files from node_modules as bin files

@jeetiss jeetiss requested a review from shuding as a code owner February 2, 2023 11:44
@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 10:23AM (UTC)

@jeetiss
Copy link
Contributor Author

jeetiss commented Feb 2, 2023

it should work when thx/resvg-js#186 will be released

@yisibl
Copy link
Contributor

yisibl commented Feb 2, 2023

Thanks!

@jeetiss
Copy link
Contributor Author

jeetiss commented Feb 2, 2023

@yisibl looks like something is wrong with bindings. it is built, but i get an error in console

Uncaught (in promise) LinkError: WebAssembly.instantiate(): Import #0 module="wbg" function="__wbg_new_15d3966e9981a196" error: function import requires a callable

check https://satori-playground-git-fork-jeetiss-update-resvg.vercel.sh/

@yisibl
Copy link
Contributor

yisibl commented Feb 2, 2023

Try this? thx/resvg-js#196

@jeetiss
Copy link
Contributor Author

jeetiss commented Feb 2, 2023

Try this? thx/resvg-js#196

It works 🚀

@yisibl
Copy link
Contributor

yisibl commented Feb 2, 2023

I just released 2.3.1 and ran your branch locally and the error was resolved.

playground/package.json Outdated Show resolved Hide resolved
@shuding shuding merged commit cf348f6 into vercel:main Feb 7, 2023
sahithyandev pushed a commit to sahithyandev/satori that referenced this pull request Feb 7, 2023
@jeetiss jeetiss deleted the update-resvg branch February 7, 2023 10:15
@github-actions
Copy link

🎉 This PR is included in version 0.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants