Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory or file name with "#" or "?" does not work properly #774

Open
kobe-koto opened this issue Jun 24, 2023 · 0 comments
Open

Directory or file name with "#" or "?" does not work properly #774

kobe-koto opened this issue Jun 24, 2023 · 0 comments

Comments

@kobe-koto
Copy link

Description

Directory or file name with "#" or "?" does not work properly.

For an example, I have a directory named DL#20230623(or DL?20230623), but actually when I try to access http://0.0.0.0/DL#20230623/(or http://0.0.0.0/DL?0230623/), it return contents which in directory DL(or 404).

I guess it because in a standard URL, string after ? or # is not in path part.

Library version

14.2.0

Node version

20.3.0

abubakriz added a commit to abubakriz/serve-handler that referenced this issue Jul 31, 2024
When a file url has certain symbols like number sign (#), it doesn't encode them, which makes the browser fail to navigate to the file, thinking it is a document section. This commit fixes that by encoding urls using the built-in encodeURIComponent function.

Fixes vercel#120, vercel#205, vercel/serve#726, and vercel/serve#774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant