-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS: Adding Ability to Send Passphrase to createServer #655
HTTPS: Adding Ability to Send Passphrase to createServer #655
Conversation
…e params for https
@leerob can you take a look at this when you can? Pretty small change, but will help in certain instances. thanks! |
Is there an open issue or more info anywhere? Why is this needed? Coming in completely blind 😄 |
ah my bad, let me know if you'd like me to open one. In general, I wanted to be able to use this within American express, but I need to be able to pass a certification authority and passphrase to the https options in order to use this, so thought I'd create a PR for it. |
@leerob Anything I can do to help here? |
Could you share a little bit more on the why? How does this work - the flags are forwarded? Are there any tests needed here? |
@leerob Added more details to the description. Removed the certificate authority portion, just kept it to passphrase and made it optional, so nothing will be affected if it's not passed. Don't see any test in this repo, but, as it's optional now, don't think it's necessary. Let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
Thanks @leerob! Any chance you can merge? |
Purpose
Adds ability to pass though an optional
passphrase
option for the ssl cert via a--ssl-pass
param tohttps.createServer
.