Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add request logging #716

Merged
merged 8 commits into from
Jul 30, 2022
Merged

feat: add request logging #716

merged 8 commits into from
Jul 30, 2022

Conversation

gamemaker1
Copy link
Contributor

Related Issues

Closes #660.

Description

  • adds request logging; logs request time, ip, method, and url, as well as the response status code and response time.
  • request logging is enabled by default, and can be disabled using --no-request-logging, or -L.

leerob
leerob reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - should we add a test?

@gamemaker1
Copy link
Contributor Author

Sure, will do

@gamemaker1
Copy link
Contributor Author

Added tests now :]

@leerob leerob merged commit 337279c into vercel:main Jul 30, 2022
@gamemaker1 gamemaker1 deleted the feat/add-request-logging branch July 30, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Where is log? Can I use serve in production environment?
2 participants
@gamemaker1 @leerob