fix(#27): sveltekit route is not always defined #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
force-pushed
the
damien/aly-1110-sveltekit-canno-read-properties-of-undefined
branch
from
7b9a2bf
to
5954ca5
Compare
feugy
force-pushed
the
damien/aly-1110-sveltekit-canno-read-properties-of-undefined
branch
from
5954ca5
to
44c82bf
Compare
feugy
force-pushed
the
damien/aly-1110-sveltekit-canno-read-properties-of-undefined
branch
from
44c82bf
to
2889995
Compare
feugy
force-pushed
the
damien/aly-1110-sveltekit-canno-read-properties-of-undefined
branch
from
2889995
to
b46a532
Compare
chriswdmr
approved these changes
Dec 8, 2023
feugy
deleted the
damien/aly-1110-sveltekit-canno-read-properties-of-undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
In a Sveltekit application, when importing
injectSpeedInsight()into a+layout.js/tsfile, the route could be undefined.🧪 How to test?
On the preview deployment, we can navigate between the 2 pages and see the metrics being collecting, and assigned to the correct route.
❗ Notes to reviewers
Please focus on
+layout.jsfile. I brought a simpler skeleton app instead of the full demo app which is irrelevant for us.This must be an edge case, because this
injectSpeedInsight()contains conditionals to only run on the client side, where therouteshould always be available.We can see the metrics correctly applied to the current route.