Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad TypeScript types #698

Closed
twavv opened this issue Feb 12, 2021 · 3 comments · Fixed by #699 or #700
Closed

Bad TypeScript types #698

twavv opened this issue Feb 12, 2021 · 3 comments · Fixed by #699 or #700
Labels
released

Comments

@twavv
Copy link

twavv commented Feb 12, 2021

Do you want to request a feature or report a bug?

Bug/issue.

What is the current behavior?

The current types list typings in package.json which claim that styled-jsx exports css... which isn't true. You actually need to import styled-jsx/css.

This also requires there to be a root level css.d.ts file (at the same level as css.js in the root of the package, not inside typings/).

Environment (include versions)

  • styled-jsx (version): 3.4.2
@theoludwig
Copy link
Contributor

Maybe it was my bad : #692
Could you open a PR to fix the types ? Thanks! 😄
@travigd

@jrandiny jrandiny mentioned this issue Feb 16, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrandiny jrandiny mentioned this issue Feb 16, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Typing module location and invalid export
fix: missing files on package.json
2 participants
@twavv @theoludwig